Open
Conversation
structure makes it easier for the future to add more
Keeping the old projects to the what seems to be the last major version of .Net Framework
Make project buildable again using newer nunit Moves ignore comment into the ignore attribute parameter Migrate Assert.Equals to Assert.That due to nunit upgrades Add testadapter to be able to run tests in visual studio
Update nuspecfile with repo url Enable codeAnalysisRuleSet Bumping one major version due to major .Net framework update
Add new project for GSMEncoding based on .Net Standard 2.0 to support as many .Net versions as possible Add new test project for migrated GSMEncoding project Add .editorconfig Add .globalconfig Update .gitignore to ignore testresults from new test project Add solution items to solution for easier management inside of visual studio
|
Considered to convert to sdkstyle projects with multi target instead, should essentially only have to modify the existing csproj file and not have multiple projects? (Nunit upgrades needed of course) |
Author
|
You are indeed correct but i created new projects based on .Net Standard 2.0 to support as many .Net versions as possible, while keeping the old ones around for specific .Net Framework support. Didn't want to remove them entirely unless mediaburts is ok with that 😅 |
|
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since .NET seemingly doesn't support GSM7/GSM 03.38/3GPP TS 23.038 text encoding built-in this seems like a useful library to make usable for newer versions of .NET. 🎉
To make the library able to be used in newer .NET version it would need to be upgraded.
So here is an upgrade of the library to .NET Framework 4.8. Major version of library was bumped to indicate this.
All non-ignored tests pass. No code changes have been made to the library. For test projects changes have only been made to support the newer version of NUnit.
To also support non-framework .NET versions, I migrated the library to new projects (MediaBurst.TextCore) side-by-side to the old, which are based on .NET Standard 2.0.
This will make it support these versions:
Hopefully we can see these upgrades to the library on NuGet soon. 🤩
Some other notes about changes
To make it easier to manage this "side-by-side projects", the solution was restructured.
/src/<projects-folder>
/Tests/<test-projects-folders>
For easier contribution standardization a
.editorconfigwas created along with.globalconfigfor analyzers.