-
Notifications
You must be signed in to change notification settings - Fork 3
Add AbortSignal support to createTimeout
#381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c7626cf
Initial plan
Copilot 54cbfee
Add AbortSignal support to createTimeout utility
Copilot fee3538
Pass abort signal to createTimeout calls in TransitionPresence
Copilot e2fe121
Tighten catch to only swallow the exact abort reason in TransitionPre…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,33 @@ | ||
| /** | ||
| * Returns a promise that resolves after given amount of time. Use the default | ||
| * value of `0` to wait for the next tick. | ||
| * | ||
| * @param ms - The number of milliseconds to wait before resolving. Defaults to `0`. | ||
| * @param options - Optional options object. | ||
| * @param options.signal - An optional AbortSignal to cancel the timeout. When aborted, the promise rejects with the signal's reason. | ||
| */ | ||
| export function createTimeout(ms = 0): Promise<void> { | ||
| return new Promise((resolve) => { | ||
| setTimeout(resolve, ms); | ||
| export function createTimeout(ms = 0, { signal }: { signal?: AbortSignal } = {}): Promise<void> { | ||
| return new Promise((resolve, reject) => { | ||
| if (signal?.aborted) { | ||
| reject(signal.reason); | ||
| return; | ||
| } | ||
|
|
||
| if (signal === undefined) { | ||
| setTimeout(resolve, ms); | ||
| return; | ||
| } | ||
|
|
||
| const onAbort = (): void => { | ||
| clearTimeout(timeoutId); | ||
| reject(signal.reason); | ||
| }; | ||
|
|
||
| const timeoutId = setTimeout(() => { | ||
| signal.removeEventListener('abort', onAbort); | ||
| resolve(); | ||
| }, ms); | ||
|
|
||
| signal.addEventListener('abort', onAbort, { once: true }); | ||
| }); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.