Skip to content

Make org-mem-entry-properties combine local and inherited#45

Open
meedstrom wants to merge 1 commit intomainfrom
change-properties-getter
Open

Make org-mem-entry-properties combine local and inherited#45
meedstrom wants to merge 1 commit intomainfrom
change-properties-getter

Conversation

@meedstrom
Copy link
Copy Markdown
Owner

@meedstrom meedstrom commented Feb 28, 2026

Closes #43

Untested.

@krisbalintona
Copy link
Copy Markdown
Contributor

krisbalintona commented Mar 1, 2026

I see some logic using the new org-mem-parser--subset-properties but still looks like all ancestor properties are still in org-mem-entry-properties-inherited and all of them are returned, not just the ones in org-use-property-inheritance.

Is it the same on your end?

@meedstrom meedstrom force-pushed the change-properties-getter branch from a35fc3f to 5f234ad Compare March 1, 2026 00:35
@meedstrom meedstrom force-pushed the change-properties-getter branch from 5f234ad to 554845e Compare March 1, 2026 00:37
@meedstrom
Copy link
Copy Markdown
Owner Author

meedstrom commented Mar 1, 2026

Is it the same on your end?

Nope, just tested, it works after rebuild & restart. Though I had to force-push a couple fixes (like for that option being at value t) but they shouldn't be why you were still seeing all properties.

@meedstrom
Copy link
Copy Markdown
Owner Author

I am getting some title collisions now though for some reason.

@krisbalintona
Copy link
Copy Markdown
Contributor

Is it the same on your end?

Nope, just tested, it works after rebuild & restart. Though I had to force-push a couple fixes (like for that option being at value t) but they shouldn't be why you were still seeing all properties.

Probably was an issue with how I did things on my end. I don't have much time on my end, and since it's pretty straightforward to verify the functionality, I'll trust your discretion, so feel free to push when you think it's right.

I'll upgrade my local org-mem and if I see anything is off I'll bring it up in #43. If not, I'll go ahead and close that issue.

@meedstrom
Copy link
Copy Markdown
Owner Author

It does seem to give me an issue where some nodes seem to be inheriting their parent's title🤪... so... won't merge yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make org-mem-entry-properties combine inherited and local properties

2 participants