Kan 30 implement support for noise diode ratios#73
Open
Conversation
… KAN-30-Implement-support-for-noise-diode-ratios
…ent-support-for-noise-diode-ratios
Collaborator
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now, the noise diodes were only used to create a flag to remove them. With this PR, we are also creating a
DataElementthat contains the noise diode ratios, i.e. the duration of noise diode firing by the dump rate for all time stamps. This is zero when no noise diode was fired in a dump.I also delete an old class here. It's not used any more.
Ran 217 tests in 4.017s