Adds ARP protocol.#5
Open
lehouatais wants to merge 2 commits intomeh:masterfrom
Open
Conversation
Contributes to issue meh#3
meh
requested changes
May 23, 2019
Owner
There was a problem hiding this comment.
I hate this review interface that doesn't make it obvious there are pending notes on the thing, and then you don't get any more notification and you forget you were alive and this happens, 5 years later you get minor nitpicks.
Sorry about that, if you're not interested in doing these changes anymore I'll address the nitpicks myself, trying to catch up with the backlog of pull requests and issues on all my projects.
| if self.payload { | ||
| return Err(ErrorKind::AlreadyDefined.into()); | ||
| } | ||
| self = self.protocol(Protocol::Arp)?; |
|
|
||
| impl<B: AsRef<[u8]>> Packet<B> { | ||
|
|
||
| pub fn hardware_type(&self) -> u16 { |
| payload: bool, | ||
| } | ||
|
|
||
|
|
| Packet::new(self.buffer.data_mut()) | ||
| } | ||
| } | ||
|
|
| Packet::unchecked(self.buffer.data_mut()).set_target_protocol_address(value)?; | ||
| Ok(self) | ||
| } | ||
|
|
| } | ||
|
|
||
| impl<B: AsRef<[u8]>> Packet<B> { | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to issue #3