Open
Conversation
Member
mattersoflight
left a comment
mattersoflight
left a comment
There was a problem hiding this comment.
Congrats on the first PR @camFoltz! See the comments below.
| plt.ylim(-1, 1) | ||
|
|
||
|
|
||
| def plotEllipse2(S1, S2, S3, S4, size=5, axes=None): |
Member
There was a problem hiding this comment.
- the Stokes parameters are named S0, S1, S2, S3 (https://en.wikipedia.org/wiki/Stokes_parameters). * it is better to give plotEllipse2 a more descriptive name, e.g., plotEllipseStokes.
Suggested change
| def plotEllipse2(S1, S2, S3, S4, size=5, axes=None): | |
| def plotEllipseStokes(S0, S1, S2, S3, size=5, axes=None): |
- Notebook sets S0 to integer and the other three Stokes parameters to float. They are all float. The maximum value of S1, S2, S3 can at most be S0, since S0 represents total intensity of light.
| arrowprops=dict(arrowstyle="->", color=color), | ||
| size=size) | ||
|
|
||
| Stokes = np.array([S1,S2,S3,S4]) |
Member
There was a problem hiding this comment.
Suggested change
| Stokes = np.array([S1,S2,S3,S4]) | |
| Stokes = np.array([S0,S1,S2,S3]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added second ellipse plotting function in plotting.py that takes in parameters of the stokes parameters. Fixed issue with interaction simulation in test_plotEllipse.ipynb and renamed to plotEllipse.ipynb