Open
Conversation
Morrism1
approved these changes
Feb 25, 2020
Collaborator
Morrism1
left a comment
Morrism1
left a comment
There was a problem hiding this comment.
Great tip. You can add more tips if you have them.
mei-li
reviewed
Feb 25, 2020
Owner
mei-li
left a comment
mei-li
left a comment
There was a problem hiding this comment.
Very nice additions and thanks for cleaning up the typos. It was done in a rush.
I have only a couple of tiny comments. Let me know what you think about them.
| ### Address comments | ||
|
|
||
| Address the comments of the review or reply to them explaining your reasoning. If see that the suggested changes make sense, make the changes locally and push the updates. Use a meaningful commit message when addressing the comments eg. `Improve wording` instead of `addressing comments` | ||
| Address the comments of the review or reply to them explaining your reasoning. If see that the suggested changes make sense, make the changes locally and save. Then add, commit and push the updates to GitHub as you did with the initial changes. |
Owner
There was a problem hiding this comment.
If see part has a typo. I can fix it afterwards as well
| ### Rewrite the last 5 commits | ||
|
|
||
| Tip: | ||
| to make your git log look more compact like this: |
Owner
There was a problem hiding this comment.
You are removing the tip with gitconfig. Do you think it was too confusing or not working?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?