Merged
Conversation
- Add time detection logic - Update tests and types - Fix linting issues
- Add time detection for 24h (HH:mm, HH:mm:ss), 12h (hh:mm AM/PM), and timezone formats - Add TIME constant to DataTypes - Add time to PATTERNS, JSON_SCHEMA_TYPE_MAP, JSON_SCHEMA_PATTERN_MAP, TYPE_PRIORITY - Fix AM/PM conversion to occur before Date creation - Fix timezone validation bug - Fix parseWithTimeFormat to validate all parts are consumed - Add comprehensive time detection tests - Update README and TypeScript definitions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR fixed the the #37
Related Issue
Fixes #25
Changes Made
isTime()function inindex.jstest/index.spec.jsindex.d.tswith TypeScript definitionsREADME.mdwith examples and countsChecklist
Required (PR will not be merged without these):
git rebase main)npm test)npm run lint)index.d.tsCode Quality:
feat:,fix:,style:, etc.)') not double quotes (")console.logstatements in codeAvoiding Conflicts