Skip to content

Fix pr 37 time detection#38

Merged
melihbirim merged 5 commits intomainfrom
fix-pr-37-time-detection
Dec 27, 2025
Merged

Fix pr 37 time detection#38
melihbirim merged 5 commits intomainfrom
fix-pr-37-time-detection

Conversation

@melihbirim
Copy link
Copy Markdown
Owner

Pull Request

Description

This PR fixed the the #37

Related Issue

Fixes #25

Changes Made

  • Added isTime() function in index.js
  • Added tests in test/index.spec.js
  • Updated index.d.ts with TypeScript definitions
  • Updated README.md with examples and counts

Checklist

Required (PR will not be merged without these):

  • Synced with latest main branch (git rebase main)
  • All tests pass (npm test)
  • Linting passes (npm run lint)
  • README.md updated with:
    • Data type added to supported types list
    • Test count updated
    • Usage example added
  • TypeScript definitions added in index.d.ts
  • JSDoc documentation added for new functions

Code Quality:

  • [ x] Followed conventional commit format (feat:, fix:, style:, etc.)
  • [ x] Used single quotes (') not double quotes (")
  • [x ] No console.log statements in code
  • [ x] Functions added at the end of file (minimizes conflicts)
  • [ x] Test cases added at the end of test file
  • [x ] Pre-commit hook ran automatically (auto-fixed linting)

Avoiding Conflicts

  • [ x] I have rebased on the latest main branch before creating this PR
  • [ x] I understand that if conflicts occur, I need to resolve them by rebasing again

Bala417 and others added 5 commits December 23, 2025 19:33
- Add time detection logic
- Update tests and types
- Fix linting issues
- Add time detection for 24h (HH:mm, HH:mm:ss), 12h (hh:mm AM/PM), and timezone formats
- Add TIME constant to DataTypes
- Add time to PATTERNS, JSON_SCHEMA_TYPE_MAP, JSON_SCHEMA_PATTERN_MAP, TYPE_PRIORITY
- Fix AM/PM conversion to occur before Date creation
- Fix timezone validation bug
- Fix parseWithTimeFormat to validate all parts are consumed
- Add comprehensive time detection tests
- Update README and TypeScript definitions
@melihbirim melihbirim merged commit c3cbffe into main Dec 27, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Duration/Time Interval Detector

2 participants