docs(machine): hedge wrapper-placement prose for framed wrappers#105
Merged
Conversation
The "Nodes" reading-guide bullet claimed wrappers always sit OUTSIDE their callable subtree's subgraph. Engine v7 fix (turing-machine-js#223) moves framed wrappers — those whose continuation chain participates in a caller's frame — INSIDE the owner frame's subgraph with the same [[…]] shape. Split the prose into top-level vs framed cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withOverriddenHaltStatewrappers always sit OUTSIDE their callable subtree'ssubgraph w_Nblock. That was true of v7 output up to alpha.6, but the engine fix in turing-machine-js #223 / PR #224 moves framed wrappers (continuation chain participates in a caller's frame) INSIDE the owner frame's subgraph with the same[[…]]shape.s7 = main-tagged), and top-level wrappers still render outside.Test plan