🚧 ci: allow to override the gui image in the review apps#1606
Open
oldgiova wants to merge 3 commits intomendersoftware:mainfrom
Open
🚧 ci: allow to override the gui image in the review apps#1606oldgiova wants to merge 3 commits intomendersoftware:mainfrom
oldgiova wants to merge 3 commits intomendersoftware:mainfrom
Conversation
2ad987e to
8b60eb1
Compare
mzedel
reviewed
Apr 1, 2026
Contributor
There was a problem hiding this comment.
may I also propose an enterprise variant of compose/k8s/review-values.yaml.tpl, so that the job can take an REVIEW_APPS_ENTERPRISE (or similar) env var into account and use the enterprise values file + the gui override to launch the enterprise preview env from here/ the OS repo?
Contributor
Author
Got it, this to shorten the feedback with the gui container tested directly over the ENT deployment before the OS > ENT sync. Smart, let me try |
8b60eb1 to
7a40e89
Compare
Allow to set a custom pre-built gui image in the review apps deployment Ticket: QA-1525 Signed-off-by: Roberto Giovanardi <roberto.giovanardi@northern.tech>
Allow review app deployments to override the GUI container image and deploy an enterprise-flavored stack directly from the OS repository. - introduce .gitlab/review_apps.yaml control file with gui_image, enterprise, and enterprise_image_tag keys - add compose/k8s/parse-review-config.sh (sourced by review:deploy) to parse the control file, validate inputs, and export Helm override flags; generates per-deployment values files for GUI and ENT-only service image overrides - add compose/k8s/review-values-enterprise.yaml.tpl: enterprise Helm values template (enterprise: true, includes tenantadm and other ENT-only services) - add compose/k8s/create-initial-user-enterprise.sh: post-deploy init script that creates a tenant and admin user via tenantadm create-org - update review:deploy in .gitlab-ci.yml to select values template and init script based on REVIEW_APPS_PROJECT_PREFIX (ent) or the enterprise key in review_apps.yaml; pass HELM_ENT_OVERRIDE_FLAG and HELM_GUI_OVERRIDE_FLAG to helm upgrade Ticket: QA-1525 Signed-off-by: Roberto Giovanardi <roberto.giovanardi@northern.tech>
88609f9 to
244eb15
Compare
Signed-off-by: Roberto Giovanardi <roberto.giovanardi@northern.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow to set a custom pre-built gui image in the review apps deployment
Ticket: QA-1525
Co-authored-with: Claude
Sample implementation:
Result: the gui image is coming from the custom override: