Skip to content

🚧 ci: allow to override the gui image in the review apps#1606

Open
oldgiova wants to merge 3 commits intomendersoftware:mainfrom
oldgiova:QA-1525-deploy-gui-os-into-ent-pr-based-deployment
Open

🚧 ci: allow to override the gui image in the review apps#1606
oldgiova wants to merge 3 commits intomendersoftware:mainfrom
oldgiova:QA-1525-deploy-gui-os-into-ent-pr-based-deployment

Conversation

@oldgiova
Copy link
Copy Markdown
Contributor

@oldgiova oldgiova commented Apr 1, 2026

Allow to set a custom pre-built gui image in the review apps deployment

Ticket: QA-1525

Co-authored-with: Claude

Sample implementation:

▶ cat .gitlab/review_apps.yaml

review_app:
  gui_image: "registry.gitlab.com/northern.tech/mender/mender-server/gui:build-e0add17f213434a02e10aab8df4489220caf2723"

Result: the gui image is coming from the custom override:

▶ kk get deploy -o yaml | grep -i image:
          image: docker.io/traefik:v3.6.11
          image: registry.gitlab.com/northern.tech/mender/mender-server/create-artifact-worker:build-8b60eb136cd03c7184defc6834a475665afda650
          image: registry.gitlab.com/northern.tech/mender/mender-server/deployments:build-8b60eb136cd03c7184defc6834a475665afda650
          image: registry.gitlab.com/northern.tech/mender/mender-server/deviceauth:build-8b60eb136cd03c7184defc6834a475665afda650
          image: registry.gitlab.com/northern.tech/mender/mender-server/deviceconfig:build-8b60eb136cd03c7184defc6834a475665afda650
          image: registry.gitlab.com/northern.tech/mender/mender-server/deviceconnect:build-8b60eb136cd03c7184defc6834a475665afda650
          image: registry.gitlab.com/northern.tech/mender/mender-server/gui:build-e0add17f213434a02e10aab8df4489220caf2723
          image: registry.gitlab.com/northern.tech/mender/mender-server/inventory:build-8b60eb136cd03c7184defc6834a475665afda650
          image: registry.gitlab.com/northern.tech/mender/mender-server/iot-manager:build-8b60eb136cd03c7184defc6834a475665afda650
          image: mongo:8.0.20
          image: natsio/nats-box:0.13.8
          image: registry.gitlab.com/northern.tech/mender/mender-server/useradm:build-8b60eb136cd03c7184defc6834a475665afda650
          image: registry.gitlab.com/northern.tech/mender/mender-server/workflows:build-8b60eb136cd03c7184defc6834a475665afda650
          image: registry.gitlab.com/northern.tech/mender/mender-server/workflows:build-8b60eb136cd03c7184defc6834a475665afda650
          image: chrislusf/seaweedfs:4.17


@oldgiova oldgiova force-pushed the QA-1525-deploy-gui-os-into-ent-pr-based-deployment branch from 2ad987e to 8b60eb1 Compare April 1, 2026 07:05
Copy link
Copy Markdown
Contributor

@mzedel mzedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may I also propose an enterprise variant of compose/k8s/review-values.yaml.tpl, so that the job can take an REVIEW_APPS_ENTERPRISE (or similar) env var into account and use the enterprise values file + the gui override to launch the enterprise preview env from here/ the OS repo?

@oldgiova
Copy link
Copy Markdown
Contributor Author

oldgiova commented Apr 1, 2026

may I also propose an enterprise variant of compose/k8s/review-values.yaml.tpl, so that the job can take an REVIEW_APPS_ENTERPRISE (or similar) env var into account and use the enterprise values file + the gui override to launch the enterprise preview env from here/ the OS repo?

Got it, this to shorten the feedback with the gui container tested directly over the ENT deployment before the OS > ENT sync. Smart, let me try

@oldgiova oldgiova force-pushed the QA-1525-deploy-gui-os-into-ent-pr-based-deployment branch from 8b60eb1 to 7a40e89 Compare April 1, 2026 07:18
oldgiova added 2 commits April 1, 2026 19:23
Allow to set a custom pre-built gui image in the review apps deployment

Ticket: QA-1525

Signed-off-by: Roberto Giovanardi <roberto.giovanardi@northern.tech>
Allow review app deployments to override the GUI container image and
deploy an enterprise-flavored stack directly from the OS repository.

- introduce .gitlab/review_apps.yaml control file with gui_image,
  enterprise, and enterprise_image_tag keys
- add compose/k8s/parse-review-config.sh (sourced by review:deploy)
  to parse the control file, validate inputs, and export Helm override
  flags; generates per-deployment values files for GUI and ENT-only
  service image overrides
- add compose/k8s/review-values-enterprise.yaml.tpl: enterprise Helm
  values template (enterprise: true, includes tenantadm and other
  ENT-only services)
- add compose/k8s/create-initial-user-enterprise.sh: post-deploy init
  script that creates a tenant and admin user via tenantadm create-org
- update review:deploy in .gitlab-ci.yml to select values template and
  init script based on REVIEW_APPS_PROJECT_PREFIX (ent) or the
  enterprise key in review_apps.yaml; pass HELM_ENT_OVERRIDE_FLAG and
  HELM_GUI_OVERRIDE_FLAG to helm upgrade

Ticket: QA-1525

Signed-off-by: Roberto Giovanardi <roberto.giovanardi@northern.tech>
@oldgiova oldgiova force-pushed the QA-1525-deploy-gui-os-into-ent-pr-based-deployment branch from 88609f9 to 244eb15 Compare April 1, 2026 17:23
Signed-off-by: Roberto Giovanardi <roberto.giovanardi@northern.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants