Skip to content

build(backend): add make target to generate all OpenAPI artifacts#1609

Open
LudvigAnderson wants to merge 1 commit intomendersoftware:mainfrom
LudvigAnderson:combined-api-flag
Open

build(backend): add make target to generate all OpenAPI artifacts#1609
LudvigAnderson wants to merge 1 commit intomendersoftware:mainfrom
LudvigAnderson:combined-api-flag

Conversation

@LudvigAnderson
Copy link
Copy Markdown
Contributor

Changelog: None

frodeha
frodeha previously approved these changes Apr 1, 2026
Copy link
Copy Markdown
Contributor

@frodeha frodeha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

backend/Makefile Outdated
Comment on lines +63 to +65
generate-openapi-all:
@$(MAKE) generate-openapi-client
@$(MAKE) tests/mender_client
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip: Could also have an empty target with dependencies:

Suggested change
generate-openapi-all:
@$(MAKE) generate-openapi-client
@$(MAKE) tests/mender_client
generate-openapi-all: generate-openapi-client tests/mender_client

Could also make the generate-openapi-spec target explicit

Suggested change
generate-openapi-all:
@$(MAKE) generate-openapi-client
@$(MAKE) tests/mender_client
generate-openapi-all: generate-openapi-spec generate-openapi-client tests/mender_client

Changelog: None
Signed-off-by: Ludvig Szklarz Anderson <ludvig.s.anderson@northern.tech>
@LudvigAnderson
Copy link
Copy Markdown
Contributor Author

Followed Alf's advice and did it the proper way with dependencies and making the other thing explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants