[Cherry 5.0.x]: fix(modules-artifact-gen): Fail early with invalid artifact + remove temporary files

[mender-test-bot]

Cherry pick of PR: #1975
For you :)

[mender-test-bot]

@mender-test-bot, start a full client pipeline with:

• mentioning me and start client pipeline

---

my commands and options

You can prevent me from automatically starting CI pipelines:

• if your pull request title starts with "[NoCI] ..."

You can trigger a client pipeline on multiple prs with:

• mentioning me and start client pipeline --pr mender/127 --pr mender-connect/255

You can trigger a client pipeline for a specific Mender Client release with:

• mentioning me and start client pipeline --release 6.0.x (can be given multiple times)
• by default, a pipeline is triggered for each supported release the component is a part of

You can trigger GitHub->GitLab branch sync with:

• mentioning me and sync

You can print PR statistics for a repository with:

• mentioning me and print fast pr stats (Team stats only)
• mentioning me and print full pr stats (Detailed report)
• options: --repo <repo>, --team <name>, --all-repos, --exclude-drafts, --exclude-user <user>
• mentioning me and print full pr stats --repo mender --all-repos --exclude-drafts

You can deploy a review app with:

• mentioning me and start review app (OS environment)
• mentioning me and start review app enterprise (Enterprise environment)

You can run e2e tests against a deployed review app with:

• mentioning me and start review tests (defaults to os environment)
• mentioning me and start review tests enterprise (for enterprise environment)

You can cherry pick to a given branch or branches with:

• mentioning me and:

 cherry-pick to:
 * 1.0.x
 * 2.0.x

[michalkopczan]

@mender-test-bot start client pipeline

[mender-test-bot]

Hello 😺 I created a pipeline for you here: Pipeline-2636789609

Build Configuration Matrix

Key	Value
BUILD_BEAGLEBONEBLACK	true
BUILD_CLIENT	true
BUILD_QEMUX86_64_BIOS_GRUB	true
BUILD_QEMUX86_64_BIOS_GRUB_GPT	true
BUILD_QEMUX86_64_UEFI_GRUB	true
BUILD_VEXPRESS_QEMU	true
BUILD_VEXPRESS_QEMU_FLASH	true
BUILD_VEXPRESS_QEMU_UBOOT_UEFI_GRUB	true
INTEGRATION_REV	3.8.x
MENDER_BINARY_DELTA_REV	1.5.x
MENDER_CONFIGURE_MODULE_REV	1.1.x
MENDER_CONNECT_REV	2.3.x
MENDER_FLASH_REV	master
MENDER_GATEWAY_REV	2.0.x
MENDER_REV	pull/1983/head
META_MENDER_REV	wrynose
META_OPENEMBEDDED_REV	wrynose
META_RASPBERRYPI_REV	wrynose
MONITOR_CLIENT_REV	1.4.x
RUN_INTEGRATION_TESTS	true
TEST_QEMUX86_64_BIOS_GRUB	true
TEST_QEMUX86_64_BIOS_GRUB_GPT	true
TEST_QEMUX86_64_UEFI_GRUB	true
TEST_VEXPRESS_QEMU	true
TEST_VEXPRESS_QEMU_FLASH	true
TEST_VEXPRESS_QEMU_UBOOT_UEFI_GRUB	true
YOCTO_REV	wrynose

[mender-test-bot]

Merging these commits will result in the following changelog entries:

Changelogs

mender (cherry-5.0.x-fix/generators-artifact-read)

New changes in mender since 5.0.x:

Bug Fixes

• Check that the file exists before claiming "success".
  The motivation is to have a more defensive generator to protect against
  mender-artifact bugs like this one:
  • fix(cli): Exit with non-zero code on invalid arguments mender-artifact#824
• Previously the generators wouldn't clean up after themselves when
  exiting half-way due to an error.

[michalkopczan]

@mender-test-bot start client pipeline

[mender-test-bot]

Hello 😺 I created a pipeline for you here: Pipeline-2637487934

Build Configuration Matrix

Key	Value
BUILD_BEAGLEBONEBLACK	true
BUILD_CLIENT	true
BUILD_QEMUX86_64_BIOS_GRUB	true
BUILD_QEMUX86_64_BIOS_GRUB_GPT	true
BUILD_QEMUX86_64_UEFI_GRUB	true
BUILD_VEXPRESS_QEMU	true
BUILD_VEXPRESS_QEMU_FLASH	true
BUILD_VEXPRESS_QEMU_UBOOT_UEFI_GRUB	true
INTEGRATION_REV	3.8.x
MENDER_BINARY_DELTA_REV	1.5.x
MENDER_CONFIGURE_MODULE_REV	1.1.x
MENDER_CONNECT_REV	2.3.x
MENDER_FLASH_REV	master
MENDER_GATEWAY_REV	2.0.x
MENDER_REV	pull/1983/head
META_MENDER_REV	wrynose
META_OPENEMBEDDED_REV	wrynose
META_RASPBERRYPI_REV	wrynose
MONITOR_CLIENT_REV	1.4.x
RUN_INTEGRATION_TESTS	true
TEST_QEMUX86_64_BIOS_GRUB	true
TEST_QEMUX86_64_BIOS_GRUB_GPT	true
TEST_QEMUX86_64_UEFI_GRUB	true
TEST_VEXPRESS_QEMU	true
TEST_VEXPRESS_QEMU_FLASH	true
TEST_VEXPRESS_QEMU_UBOOT_UEFI_GRUB	true
YOCTO_REV	wrynose