Disable auto-shutdown when externally powered, add auto-shutdown warning for OLED displays#2663
Open
oltaco wants to merge 4 commits into
Open
Disable auto-shutdown when externally powered, add auto-shutdown warning for OLED displays#2663oltaco wants to merge 4 commits into
oltaco wants to merge 4 commits into
Conversation
Member
|
Just wondering if, instead of HAS_EINK_DISPLAY, add a new DisplayDriver virtual bool isEInk() ?? |
oltaco
force-pushed
the
no-autoshutdown-when-powered
branch
from
d5093f0 to
e449af1
Compare
Member
Author
|
@ripplebiz good call, much tidier and only new e-ink display drivers need to remember to implement isEink() I've made the changes, tested on T-Echo Card and ThinkNode M1, should be good to go. |
liamcottle
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR skips low battery auto-shutdown if isExternalPowered() returns true, and also introduces a 3 second warning for OLED displays before auto-shutdown.
Currently only works for NRF52 boards, ESP32 would probably need board-level overrides I think.