fix: contact sync across simple_repeater and companion_radio#2673
Open
NickDunklee wants to merge 1 commit into
Open
fix: contact sync across simple_repeater and companion_radio#2673NickDunklee wants to merge 1 commit into
NickDunklee wants to merge 1 commit into
Conversation
- hasPendingWork() extended so simple_repeater and
companion_radio both gate sleep and shutdown for
pending contact writes
- shutdown loops using hasPendingWork instead of ShutdownHandler
idea in previous PR
- UITask shutdown behavior - all three variants (ui-new,
ui-tiny, ui-orig) now set a _wants_shutdown flag instead of
calling powerOff() directly
- "Power off in 5 seconds…" messages added everywhere a
shutdown is announced
- "all" (hopefully) eInk displays are now tagged together
using isEInk() constant
- "all" eInk displays will send a final "Shut Down" message
so the displays show "Shut Down" after a successful shutdown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a cleanup and is in ref to my comments in #2627
@ripplebiz had some recommendations for existing code flows, so I refactored to leverage that. It compiles against a few sensor/repeater/companion node types, but I haven't tested it yet. Figured I'd get eyes on it first before going further. Brain fried now from the file/code juggling, hah. May take a couple of days to check back.
_wants_shutdownflag instead of callingpowerOff()directlyisEInk()constant