Update README.md#63
Conversation
Signed-off-by: Raunak Madan <143412156+CodexRaunak@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
This pull request updates the README.md to migrate various links, badges, and image sources from the 'layer5' organization to 'meshery'. It also streamlines community-related descriptions and removes outdated event references. Review feedback identifies a syntax inconsistency with an extra space in an HTML attribute and a duplicated width attribute in an image tag.
|
|
||
| <p style="clear:both;"> | ||
| <a href ="https://meshery.io/community"><img alt="MeshMates" src=".github/assets/images/readme/layer5-community-sign.png" style="margin-right:36px; margin-bottom:7px;" width="140px" align="left" /></a> | ||
| <a href ="https://meshery.io/community"><img alt="MeshMates" src="https://raw.githubusercontent.com/meshery/meshery/master/.github/assets/images/readme/community.png" style="margin-right:36px; margin-bottom:7px;" width="140px" align="left" /></a> |
There was a problem hiding this comment.
There is an unnecessary space before the equals sign in the href attribute. Removing it improves consistency with other links in the document.
| <a href ="https://meshery.io/community"><img alt="MeshMates" src="https://raw.githubusercontent.com/meshery/meshery/master/.github/assets/images/readme/community.png" style="margin-right:36px; margin-bottom:7px;" width="140px" align="left" /></a> | |
| <a href="https://meshery.io/community"><img alt="MeshMates" src="https://raw.githubusercontent.com/meshery/meshery/master/.github/assets/images/readme/community.png" style="margin-right:36px; margin-bottom:7px;" width="140px" align="left" /></a> |
| <div style="display: flex; justify-content: center; align-items:center;"> | ||
| <div> | ||
| <a href="https://meshery.io/community"><img alt="Layer5 Cloud Native Community" src="https://docs.meshery.io/assets/img/readme/community.png" width="140px" style="margin-right:36px; margin-bottom:7px;" width="140px" align="left"/></a> | ||
| <a href="https://meshery.io/community"><img alt="Meshery Cloud Native Community" src="https://raw.githubusercontent.com/meshery/meshery/master/.github/assets/images/meshery/meshery-logo.svg" width="140px" style="margin-right:36px; margin-bottom:7px;" width="140px" align="left"/></a> |
There was a problem hiding this comment.
The width attribute is duplicated in this <img> tag. Additionally, adding a space before the self-closing tag /> would maintain consistency with other image tags in the file.
| <a href="https://meshery.io/community"><img alt="Meshery Cloud Native Community" src="https://raw.githubusercontent.com/meshery/meshery/master/.github/assets/images/meshery/meshery-logo.svg" width="140px" style="margin-right:36px; margin-bottom:7px;" width="140px" align="left"/></a> | |
| <a href="https://meshery.io/community"><img alt="Meshery Cloud Native Community" src="https://raw.githubusercontent.com/meshery/meshery/master/.github/assets/images/meshery/meshery-logo.svg" width="140px" style="margin-right:36px; margin-bottom:7px;" align="left" /></a> |
|
Thanks for your contribution to Meshery! 🎉
|
Notes for Reviewers
Signed commits