Align Android message status wording#6133
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Hello @RCGV1 -- This is excellent. I have already volunteered to help documentation for the Android UI as soon as the details are sorted. |
|
A few things before this comes out of draft:
The core wording/logic change looks clean (no |
jamesarich
left a comment
There was a problem hiding this comment.
Requesting changes — three items to resolve before this leaves draft (detail in the comment above):
- Revert the 36 Crowdin-managed locale docs.
crowdin.ymlownsdocs/{code}/user/; hand-editing them corrupts localized content (English injected into non-English tables, e.g.docs/ar-rSA/user/messages-and-channels.md:80) and gets clobbered on the next sync. Keep onlydocs/en/user/messages-and-channels.md. This drops the PR from 44 files to ~6. - Commit the screenshot goldens for the new
MessageItemPreviews.ktstates —screenshot-checkis red without them. - Document the
NO_CHANNELbehavior change (Message.kt:166makes channel/key-mismatch failures retryable + warning-colored) in the description, and confirm it's intended — it's a behavior change, not just wording.
The core logic/wording change itself looks clean.
Summary
UI validation
Local status-state screenshots were generated and reviewed. Evidence images are embedded below from an evidence-only branch; screenshot files are intentionally not committed to this PR branch.
Validation
./gradlew :screenshot-tests:updateDebugScreenshotTest --no-daemonpassed for local UI validation../gradlew spotlessApply --no-daemonpassed../gradlew detekt --no-daemonpassed../gradlew test --no-daemonpassed.Hardware verification
Not yet performed. This PR is draft until Android hardware verification is complete.