Skip to content

Align Android message status wording#6133

Draft
RCGV1 wants to merge 1 commit into
meshtastic:mainfrom
RCGV1:codex/message-status-routing-followup
Draft

Align Android message status wording#6133
RCGV1 wants to merge 1 commit into
meshtastic:mainfrom
RCGV1:codex/message-status-routing-followup

Conversation

@RCGV1

@RCGV1 RCGV1 commented Jul 7, 2026

Copy link
Copy Markdown
Member

Summary

UI validation

Local status-state screenshots were generated and reviewed. Evidence images are embedded below from an evidence-only branch; screenshot files are intentionally not committed to this PR branch.

Android message status states - light

Android message status states - dark

Validation

  • ./gradlew :screenshot-tests:updateDebugScreenshotTest --no-daemon passed for local UI validation.
  • ./gradlew spotlessApply --no-daemon passed.
  • ./gradlew detekt --no-daemon passed.
  • ./gradlew test --no-daemon passed.

Hardware verification

Not yet performed. This PR is draft until Android hardware verification is complete.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8cbf21ec-467c-4102-a9ba-39ce43b3c139

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@roberthadow

Copy link
Copy Markdown

Hello @RCGV1 --

This is excellent. I have already volunteered to help documentation for the Android UI as soon as the details are sorted.

@jamesarich

Copy link
Copy Markdown
Collaborator

A few things before this comes out of draft:

  1. Scope / translations. Most of the 44 files are the 36 hand-edited docs/<locale>/user/messages-and-channels.md files. Those are Crowdin-managed outputs (crowdin.yml maps translations to docs/{code}/user/), so these edits will be overwritten on the next sync — and right now they inject English into localized docs (e.g. docs/ar-rSA/user/messages-and-channels.md:80 shows "Failed to deliver to mesh" in the Arabic table). Please revert all non-English docs and keep only docs/en/user/messages-and-channels.md; Crowdin handles the rest. That drops this to ~6 files.

  2. screenshot-check is red. The new preview states in MessageItemPreviews.kt don't have committed golden PNGs. Please run the screenshot-update task and commit them.

  3. Undocumented behavior change. Message.kt:166 removes NO_CHANNEL from nonRetryableMessageRoutingErrors, which makes channel/key-mismatch failures retryable and warning-colored (MessageItem.kt:399). That's a real behavior change, not just wording — please call it out in the description and confirm it's intended.

The core wording/logic change looks clean (no values-*/strings.xml edits, index regenerated, tests added).

@jamesarich jamesarich left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes — three items to resolve before this leaves draft (detail in the comment above):

  1. Revert the 36 Crowdin-managed locale docs. crowdin.yml owns docs/{code}/user/; hand-editing them corrupts localized content (English injected into non-English tables, e.g. docs/ar-rSA/user/messages-and-channels.md:80) and gets clobbered on the next sync. Keep only docs/en/user/messages-and-channels.md. This drops the PR from 44 files to ~6.
  2. Commit the screenshot goldens for the new MessageItemPreviews.kt states — screenshot-check is red without them.
  3. Document the NO_CHANNEL behavior change (Message.kt:166 makes channel/key-mismatch failures retryable + warning-colored) in the description, and confirm it's intended — it's a behavior change, not just wording.

The core logic/wording change itself looks clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants