fix: align channel QR share contract#6325
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughChannel sharing now omits ChangesChannel sharing
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
ChannelSetwithoutlora_config, while retaining?add=true.QrDialog, with a focused Replace-flow regression test.Deliberately Out Of Scope
This is the first focused contract change only. Channel-capacity and duplicate conflict UX, a unified intake/share workflow, system share or deep-link entry points, and reboot/resync handling remain tracked in #6324.
Validation
Passed locally with Homebrew OpenJDK 25 and the Android command-line tools configured.
Refs meshtastic/design#128
Refs #6324
Summary by CodeRabbit