Testing framework WIP and XeDSA signing infra#123
Merged
thebentern merged 15 commits intomasterfrom Aug 18, 2025
Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a comprehensive testing framework and XEdDSA signing infrastructure for the Meshtastic C# library. The changes include device discovery capabilities, cryptographic signing features, and integration testing infrastructure to support real hardware testing scenarios.
- Device discovery system for Linux and macOS USB devices with Meshtastic vendor ID detection
- XEdDSA (Extended EdDSA) signing implementation for NodeInfo packet authentication
- Integration testing framework with hardware device support and automated discovery
Reviewed Changes
Copilot reviewed 19 out of 22 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| protobufs | Updated subproject commit reference |
| Meshtastic/Meshtastic.csproj | Added LibUsbDotNet package dependency |
| Meshtastic/Discovery/MeshtasticDevice.cs | Device model with hardware detection logic |
| Meshtastic/Discovery/DeviceDiscovery.cs | Cross-platform USB device discovery implementation |
| Meshtastic/Data/MessageFactories/NodeInfoMessageFactory.cs | Factory for creating signed NodeInfo messages |
| Meshtastic/Crypto/XEdDSASigning.cs | XEdDSA cryptographic signing implementation |
| Meshtastic.IntegrationTest/* | Complete integration testing framework |
| Directory.Packages.props | Added LibUsbDotNet package version |
Comments suppressed due to low confidence (1)
Meshtastic/Crypto/XEdDSASigning.cs:55
- Missing using directive for System.Text. The code uses
Encoding.ASCII.GetBytes()on line 55 but the using directive is not present at the top of the file.
byte[] domain = Encoding.ASCII.GetBytes("XEdDSA");
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.