Skip to content

Remove some deadcode #11034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thebentern merged 5 commits into from
Jul 16, 2026
+0 −38
Merged

Remove some deadcode #11034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
279c1eb
chore: remove empty handleWebResponse() stub in PiWebServer
Jorropo Jul 16, 2026
9b93e95
chore: remove unused PowerStatus::knowsUSB()
Jorropo Jul 16, 2026
e8da233
chore: remove orphaned fsListFiles() declaration
Jorropo Jul 16, 2026
0ebd27c
chore: remove stale #if 0 SPI-comms test in SX126xInterface
Jorropo Jul 16, 2026
764ac0c
chore: remove stale #if 0 cert-delete debug block in WebServer
Jorropo Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/FSCommon.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ using namespace Adafruit_LittleFS_Namespace;
#endif

void fsInit();
void fsListFiles();
bool copyFile(const char *from, const char *to);
bool renameFile(const char *pathFrom, const char *pathTo);
Comment thread
Jorropo marked this conversation as resolved.
bool fsFormat();
Expand Down
3 changes: 0 additions & 3 deletions src/PowerStatus.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ class PowerStatus : public Status

bool getHasUSB() const { return hasUSB == OptTrue; }

/// Can we even know if this board has USB power or not
bool knowsUSB() const { return hasUSB != OptUnknown; }

bool getIsCharging() const { return isCharging == OptTrue; }
Comment thread
Jorropo marked this conversation as resolved.

int getBatteryVoltageMv() const { return batteryVoltageMv; }
Expand Down
24 changes: 0 additions & 24 deletions src/mesh/SX126xInterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,30 +173,6 @@ template <typename T> bool SX126xInterface<T>::init()
LOG_WARN("Failed to apply SX1262 register 0x8B5 patch for RX improvement");
}

#if 0
// Read/write a register we are not using (only used for FSK mode) to test SPI comms
uint8_t crcLSB = 0;
int err = lora.readRegister(SX126X_REG_CRC_POLYNOMIAL_LSB, &crcLSB, 1);
if(err != RADIOLIB_ERR_NONE)
RECORD_CRITICALERROR(CriticalErrorCode_SX1262Failure);

//if(crcLSB != 0x0f)
// RECORD_CRITICALERROR(CriticalErrorCode_SX1262Failure);

crcLSB = 0x5a;
err = lora.writeRegister(SX126X_REG_CRC_POLYNOMIAL_LSB, &crcLSB, 1);
if(err != RADIOLIB_ERR_NONE)
RECORD_CRITICALERROR(CriticalErrorCode_SX1262Failure);

err = lora.readRegister(SX126X_REG_CRC_POLYNOMIAL_LSB, &crcLSB, 1);
if(err != RADIOLIB_ERR_NONE)
RECORD_CRITICALERROR(CriticalErrorCode_SX1262Failure);

if(crcLSB != 0x5a)
RECORD_CRITICALERROR(CriticalErrorCode_SX1262Failure);
// If we got this far register accesses (and therefore SPI comms) are good
#endif

if (res == RADIOLIB_ERR_NONE)
res = lora.setCRC(RADIOLIB_SX126X_LORA_CRC_ON);

Expand Down
8 changes: 0 additions & 8 deletions src/mesh/http/WebServer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,14 +96,6 @@ static void taskCreateCert(void *parameter)
{
prefs.begin("MeshtasticHTTPS", false);

#if 0
// Delete the saved certs (used in debugging)
LOG_DEBUG("Delete any saved SSL keys");
// prefs.clear();
prefs.remove("PK");
prefs.remove("cert");
#endif

LOG_INFO("Checking if we have a saved SSL Certificate");

size_t pkLen = prefs.getBytesLength("PK");
Expand Down
2 changes: 0 additions & 2 deletions src/mesh/raspihttp/PiWebServer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,6 @@ int callback_static_file(const struct _u_request *request, struct _u_response *r
}
}

static void handleWebResponse() {}

/*
* Adapt the radioapi to the Webservice handleAPIv1ToRadio
* Trigger : WebGui(SAVE)->WebServcice->phoneApi
Expand Down
Loading