Skip to content

TrafficManagement: gate role/NodeInfo cache writes on signer authenticity #11048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NomDeTom merged 3 commits into from
Jul 17, 2026
Merged

TrafficManagement: gate role/NodeInfo cache writes on signer authenticity #11048

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9dc977b
TrafficManagement: gate role/NodeInfo cache writes on signer authenti…
caveman99 Jul 17, 2026
30be1c8
TrafficManagement: hoist shared NodeInfo signer lookup
caveman99 Jul 17, 2026
f33544e
Merge branch 'develop' into trafficmgmt-cache-gating
thebentern Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/modules/TrafficManagementModule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,9 +726,16 @@ ProcessMessage TrafficManagementModule::handleReceived(const meshtastic_MeshPack
return ProcessMessage::CONTINUE;
}

// A known signer's NodeInfo arriving unsigned is unauthenticated (the sender is forgeable), so
// it must not drive any cache or identity write below. Computed once here (getMeshNode is O(N))
// and reused by both the cache-refresh and the direct-response identity path.
const bool isNodeInfo = mp.decoded.portnum == meshtastic_PortNum_NODEINFO_APP;
const meshtastic_NodeInfoLite *senderNode = isNodeInfo ? nodeDB->getMeshNode(getFrom(&mp)) : nullptr;
const bool unauthenticatedSigner = senderNode && nodeInfoLiteHasXeddsaSigned(senderNode) && !mp.xeddsa_signed;

// Learn NodeInfo payloads into the dedicated PSRAM cache, and refresh the tier-3
// role cache for any node we already track (keeps the dedup role exception current).
if (mp.decoded.portnum == meshtastic_PortNum_NODEINFO_APP) {
if (isNodeInfo && !unauthenticatedSigner) {
cacheNodeInfoPacket(mp);
updateCachedRoleFromNodeInfo(mp);
}
Expand All @@ -746,8 +753,7 @@ ProcessMessage TrafficManagementModule::handleReceived(const meshtastic_MeshPack
if (shouldRespondToNodeInfo(&mp, true)) {
// Unicast NodeInfo is never signed, so a known signer's identity claim here is
// unauthenticated: don't overwrite its stored name. The cached response is unaffected.
const meshtastic_NodeInfoLite *senderNode = nodeDB->getMeshNode(getFrom(&mp));
const bool unauthenticatedSigner = senderNode && nodeInfoLiteHasXeddsaSigned(senderNode) && !mp.xeddsa_signed;
// unauthenticatedSigner was computed above (this branch is NodeInfo-only).
meshtastic_User requester = meshtastic_User_init_zero;
if (!unauthenticatedSigner &&
pb_decode_from_bytes(mp.decoded.payload.bytes, mp.decoded.payload.size, &meshtastic_User_msg, &requester)) {
Expand Down
Loading