fix: distinguish undecryptable direct messages from channel failures - #11244
Open
RCGV1 wants to merge 1 commit into
Open
fix: distinguish undecryptable direct messages from channel failures#11244RCGV1 wants to merge 1 commit into
RCGV1 wants to merge 1 commit into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughPKI routing now distinguishes undecryptable encrypted packets from unknown public keys and reports a dedicated NAK. Tests cover the new routing errors and related channel/key cases. The protobufs subproject pin also advances to a newer revision. ChangesPKI routing error handling
Protobuf revision update
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant Test as C13 test
participant Router as AuthPipelineRouter
participant Reliable as ReliableRouter
participant Routing as AuthPipelineRoutingModule
Test->>Router: sniff(encrypted PKI packet)
Router->>Reliable: sniffReceived(packet)
Reliable->>Routing: sendAckNak(PKI_DECRYPT_FAILED)
Routing-->>Test: record lastAckError
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
⚡ Try this PR in the Web Flasher
Warning This is an automated, unreviewed CI test build. Back up your device configuration Supported boards built by this PR (31)
Build artifacts expire on 2026-08-25. Updated for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an addressed PKI direct message cannot authenticate with a public key already stored for its sender, reply with
PKI_DECRYPT_FAILEDinstead ofNO_CHANNEL.PKI_UNKNOWN_PUBKEYremains the response when the sender key is absent, and ordinary encrypted channel failures still returnNO_CHANNEL.Depends on meshtastic/protobufs#1022.
Validation
pio test -e native-macos -f test_packet_signing(60 passed)pio test -e native-macos -f test_mesh_module(24 passed)pio run -e tbeam-s3-corepio run -e t-echoSummary by CodeRabbit