feat: add RAK WisMesh Pocket / Repeater Mini / Pod hardware models - #1019
Open
Ethan-chen1234-zy wants to merge 1 commit into
Open
feat: add RAK WisMesh Pocket / Repeater Mini / Pod hardware models#1019Ethan-chen1234-zy wants to merge 1 commit into
Ethan-chen1234-zy wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesHardware model identifiers
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds official
HardwareModelenum values for RAKwireless WisMesh product variants that already have firmware envs merged (or in flight), so devices can report distinct models for App OTA matching, NodeInfo, and Web Flasher metadata — instead of inheriting parent models (RAK4631/RAK3401/WISMESH_TAG).New HardwareModel values
WISMESH_POCKETWISMESH_REPEATER_MINIWISMESH_REPEATER_MINI_HPWISMESH_PODWhy now
RAK4631(e.g. GPSPIN_GPS_EN/ power behavior); sharing parenthw_modelrisks wrong App OTA target and incorrect GPS EN special-casing.Follow-up (firmware, separate PR)
After this merges and firmware protobufs sync:
HW_VENDORinsrc/platform/nrf52/architecture.h(before parentRAK4630/WISMESH_TAGbranches)custom_meshtastic_hw_model/custom_meshtastic_hw_model_slugon each envChecklist before merging
Summary by CodeRabbit