Skip to content

feat: add RAK WisMesh Pocket / Repeater Mini / Pod hardware models - #1019

Open
Ethan-chen1234-zy wants to merge 1 commit into
meshtastic:masterfrom
Ethan-chen1234-zy:feat/wismesh-hardware-models
Open

feat: add RAK WisMesh Pocket / Repeater Mini / Pod hardware models#1019
Ethan-chen1234-zy wants to merge 1 commit into
meshtastic:masterfrom
Ethan-chen1234-zy:feat/wismesh-hardware-models

Conversation

@Ethan-chen1234-zy

@Ethan-chen1234-zy Ethan-chen1234-zy commented Jul 24, 2026

Copy link
Copy Markdown

What does this PR do?

Adds official HardwareModel enum values for RAKwireless WisMesh product variants that already have firmware envs merged (or in flight), so devices can report distinct models for App OTA matching, NodeInfo, and Web Flasher metadata — instead of inheriting parent models (RAK4631 / RAK3401 / WISMESH_TAG).

Related firmware envs: rak_wismesh_pocket, rak_wismesh_repeater_mini, rak_wismesh_repeater_mini_hp, rak_wismesh_pod

New HardwareModel values

ID Enum Product
144 WISMESH_POCKET RAK WisMesh Pocket V3
145 WISMESH_REPEATER_MINI RAK WisMesh Repeater Mini V2
146 WISMESH_REPEATER_MINI_HP RAK WisMesh Repeater Mini V2 HP
147 WISMESH_POD RAK WisMesh Pod

Why now

  • Pocket diverges from generic RAK4631 (e.g. GPS PIN_GPS_EN / power behavior); sharing parent hw_model risks wrong App OTA target and incorrect GPS EN special-casing.
  • Repeater Mini / HP / Pod currently run on parent models; dedicated IDs give correct product identity before a public release ships.
  • RAK is a Meshtastic partner; requesting official model numbers prior to release.

Follow-up (firmware, separate PR)

After this merges and firmware protobufs sync:

  • Map HW_VENDOR in src/platform/nrf52/architecture.h (before parent RAK4630 / WISMESH_TAG branches)
  • Set custom_meshtastic_hw_model / custom_meshtastic_hw_model_slug on each env

Checklist before merging

  • All top level messages commented
  • All enum members have unique descriptions

Summary by CodeRabbit

  • New Features
    • Added support for identifying four RAKwireless WisMesh device models:
      • WisMesh Pocket
      • WisMesh Repeater Mini
      • WisMesh Repeater Mini HP
      • WisMesh Pod

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: be2fff9b-c936-419c-8e9b-021ad59be164

📥 Commits

Reviewing files that changed from the base of the PR and between bfd718f and 3ef15bc.

📒 Files selected for processing (1)
  • meshtastic/mesh.proto

📝 Walkthrough

Walkthrough

The HardwareModel protobuf enum now includes four RAKwireless WisMesh device identifiers: Pocket, Repeater Mini, Repeater Mini HP, and Pod.

Changes

Hardware model identifiers

Layer / File(s) Summary
Add WisMesh enum values
meshtastic/mesh.proto
Adds WISMESH_POCKET (144), WISMESH_REPEATER_MINI (145), WISMESH_REPEATER_MINI_HP (146), and WISMESH_POD (147) to HardwareModel.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: thebentern, jp-bennett, caveman99

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the added RAK WisMesh hardware models and matches the change set.
Description check ✅ Passed The description is complete and aligned with the template, including what changed, why, checklist items, and follow-up notes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thebentern
thebentern requested a review from caveman99 July 24, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant