feat: add remote telemetry request policies - #1023
Open
RCGV1 wants to merge 3 commits into
Open
Conversation
📝 WalkthroughWalkthrough
ChangesSecurity policy schema
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@meshtastic/config.proto`:
- Around line 1296-1310: Regenerate the committed protobuf bindings from the
updated schema so packages/ts/lib/meshtastic/config_pb.ts and any other
generated artifacts include LocalStatsRequestPolicy and localStatsRequestPolicy.
Verify the generated TypeScript supports reading, setting, and exposing the new
field, then commit the refreshed artifacts rather than relying only on buf lint.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 2a795c6a-5aa9-44ae-b01f-c4206168d36b
📒 Files selected for processing (2)
meshtastic/config.protomeshtastic/module_config.proto
This was referenced Jul 27, 2026
Open
feat: configure LocalStats request privacy and PKI remote refresh
meshtastic/Meshtastic-Android#6459
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds two device-owned
SecurityConfigrequest policies for detailed radio telemetry:local_stats_request_policycontrols detailed LocalStats.device_telemetry_request_policycontrols requested DeviceMetrics only whileTelemetryConfig.device_telemetry_enabledis false. It is ignored while DeviceMetrics broadcasting is enabled.Each policy is an enum with a compatible default,
CHANNEL, and an opt-inADMIN_PKImode.CHANNELkeeps normal shared-channel encryption.ADMIN_PKIallows firmware to require a PKI-authenticated request from a configured remote-admin key. Direct attached-client requests remain trusted.This does not add NodeInfo/capability broadcasting or publish remote-admin membership. Remote clients choose the transport only at a user-initiated request; firmware returns the existing correlated
NOT_AUTHORIZEDrouting NAK when that method or identity is rejected.Validation
buf format --diff --exit-codebuf lintbuf breaking --against https://github.com/meshtastic/protobufs.git#format=git,commit=bfd718fa1dcb019ed11b7b7185f37318abebdafcbuf generate; verified TypeScript emits both policy enums and fields. Generated TypeScript is intentionally ignored and regenerated by the publish workflow.Checklist before merging