Skip to content

Add explicit presence for arrival time: MeshPacket.rx_time optional - #1025

Merged
thebentern merged 1 commit into
meshtastic:masterfrom
NomDeTom:arrival-time-fix-perhaps
Jul 29, 2026
Merged

Add explicit presence for arrival time: MeshPacket.rx_time optional#1025
thebentern merged 1 commit into
meshtastic:masterfrom
NomDeTom:arrival-time-fix-perhaps

Conversation

@NomDeTom

@NomDeTom NomDeTom commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Needed for meshtastic/firmware#11274

Summary by CodeRabbit

  • Bug Fixes
    • Packet reception timestamps can now be explicitly marked as unavailable when a reliable clock source is not present.
    • Improved distinction between an unknown timestamp and a valid Unix epoch timestamp.

@NomDeTom
NomDeTom marked this pull request as draft July 28, 2026 20:44
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

MeshPacket.rx_time is now an explicitly optional protobuf field, with documentation describing timestamp absence when no reliable wall clock is available.

Changes

MeshPacket timestamp contract

Layer / File(s) Summary
Optional reception timestamp contract
meshtastic/mesh.proto
MeshPacket.rx_time uses proto3 optional presence semantics, and its documentation distinguishes absent timestamps from Unix epoch values and allows later re-timestamping.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: thebentern, jp-bennett, caveman99

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is far too minimal and does not follow the required template sections or checklist. Add the required 'What does this PR do?' section, replace the placeholder issue link if needed, and include the checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly states the main change: making MeshPacket.rx_time optional for explicit presence.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@NomDeTom

Copy link
Copy Markdown
Contributor Author

@jamesarich another minor change.

@NomDeTom
NomDeTom marked this pull request as ready for review July 28, 2026 21:17
@thebentern
thebentern merged commit 6ceceae into meshtastic:master Jul 29, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants