chore: adopt buf 1.71 — reformat powermon.proto + pin buf in CI (Renovate-managed)#953
Merged
Merged
Conversation
buf-action runs the latest buf (now 1.71.0), which normalizes block-comment indentation differently than the version master was last formatted with. This applies that formatting so the PR format check passes; no schema change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest Buf updates on your PR. Results from workflow pull-request / build (pull_request).
|
Pins the buf CLI in the three bufbuild/buf-action usages so the format/lint/breaking checks are deterministic instead of floating to latest. A renovate.json customManager tracks bufbuild/buf releases via inline # renovate: annotations, so bumps arrive as reviewable PRs (Renovate's github-actions manager only bumps the action tag, not the with: version input). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jamesarich
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two related buf-CI changes:
1. Reformat
powermon.proto(buf 1.71)buf-actionruns the latestbuf(now 1.71.0), which normalizes block-comment indentation differently than the versionmasterwas last formatted with — so thebuild(bufformat) check fails repo-wide onmeshtastic/powermon.proto, independent of any content change (master's last green run predated 1.71.0). This applies 1.71's formatting. Comment-only; no schema change.2. Pin buf + let Renovate manage it
Root-cause fix so this doesn't recur: the three
bufbuild/buf-actionusages (pull_request,schema-registry,create_tag) now pinversion: 1.71.0instead of floating to "latest", so the format/lint/breaking checks are deterministic. Arenovate.jsoncustomManager tracksbufbuild/bufGitHub releases via the inline# renovate: datasource=github-releases depName=bufbuild/bufannotations — so buf bumps arrive as reviewable Renovate PRs, and any formatting change lands only when that PR is merged (with the diff visible).Why the customManager is needed: Renovate's stock
github-actionsmanager only bumps the@v1.2.0action tag, not thewith: version:input. Validated withrenovate-config-validator✅.Surfaced while working on #952; kept separate to keep that PR focused.
publish.yml'sbuf-setup-actionis intentionally left out here (since #952 already edits that file) — can be pinned in a follow-up.🤖 Generated with Claude Code