Emdash begone#972
Open
NomDeTom wants to merge 3 commits into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe change normalizes dash punctuation across documentation and workflow text, adds a pull-request workflow to reject Unicode dashes in selected files, and adds ChangesDash normalization and telemetry update
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
NomDeTom
marked this pull request as draft
July 1, 2026 22:14
NomDeTom
marked this pull request as ready for review
July 1, 2026 22:15
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/ascii-dash.yml (1)
20-21: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winDisable unnecessary checkout credential persistence.
This job performs no authenticated Git operations, so set
persist-credentials: falseto avoid leaving the token available to later steps. (github.com)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/ascii-dash.yml around lines 20 - 21, Update the “Checkout code” step using actions/checkout@v4 to set persist-credentials to false, ensuring the checkout token is not retained for subsequent workflow steps.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ascii-dash.yml:
- Around line 28-32: Update the git grep check in the workflow so exit code 1
continues to mean no matches, while any other nonzero exit is treated as a
command failure and causes the job to fail. Preserve the existing error and exit
behavior when dash matches are found.
---
Nitpick comments:
In @.github/workflows/ascii-dash.yml:
- Around line 20-21: Update the “Checkout code” step using actions/checkout@v4
to set persist-credentials to false, ensuring the checkout token is not retained
for subsequent workflow steps.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 6df6fb36-293b-4fc8-8862-4dfe0218f409
📒 Files selected for processing (12)
.github/workflows/ascii-dash.yml.github/workflows/snapshot-kmp.ymlmeshtastic/admin.protomeshtastic/atak.optionsmeshtastic/atak.protomeshtastic/mesh.optionsmeshtastic/mesh.protomeshtastic/mesh_beacon.protomeshtastic/module_config.protomeshtastic/telemetry.protopackages/kmp/README.mdpackages/kmp/build.gradle.kts
🚧 Files skipped from review as they are similar to previous changes (8)
- meshtastic/mesh.options
- meshtastic/mesh_beacon.proto
- meshtastic/atak.options
- meshtastic/telemetry.proto
- meshtastic/admin.proto
- meshtastic/module_config.proto
- .github/workflows/snapshot-kmp.yml
- meshtastic/atak.proto
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.trunk/actions:
- Line 1: Replace the machine-local absolute symlinks with portable repository
state: for .trunk/actions, .trunk/logs, .trunk/notifications, .trunk/out, and
.trunk/tools, use relative links only when their targets are repository-managed;
otherwise remove these generated entries from version control and recreate them
during Trunk setup.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 6390bc83-6725-441f-b321-c4370e904817
📒 Files selected for processing (6)
.github/workflows/ascii-dash.yml.trunk/actions.trunk/logs.trunk/notifications.trunk/out.trunk/tools
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/ascii-dash.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes all em-dashes from this repo, and introduces another PR-level check that prevents new ones from being put in.
Summary by CodeRabbit
New Features
Documentation
Chores