Add transparent_mode to config.proto#975
Conversation
|
The latest Buf updates on your PR. Results from workflow pull-request / build (pull_request).
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdded a new boolean field, ChangesLoRaConfig transparent_mode field
Estimated code review effort: 1 (Trivial) | ~3 minutes Related PRs: None identified. Suggested labels: proto, enhancement Suggested reviewers: None identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
meshtastic/config.proto (1)
1253-1258: 🔒 Security & Privacy | 🔵 TrivialConfirm gating for a field that disables mesh encryption/routing.
transparent_modebypasses both mesh routing and encryption/decryption, andLoRaConfigis transported throughChannelSet.lora_config(meshtastic/apponly.proto) which backs shareable channel configs/QR codes. Since this schema change alone doesn't show how the setting is gated in firmware/client, worth confirming that enabling it requires appropriate authorization (e.g., admin session) rather than being settable via casual channel-config exchange, given it fully disables encrypted, routed mesh transport.Defines the app-only ChannelSet API contract that includes a Config.LoRaConfig lora_config field.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@meshtastic/config.proto` around lines 1253 - 1258, The new transparent_mode field in LoRaConfig disables encryption and mesh routing, so it must not be freely settable through ordinary ChannelSet/lora_config exchange. Confirm and enforce the existing authorization gate in the firmware/client path that applies Config.LoRaConfig updates, and require an admin-authorized session (or equivalent privileged flow) before transparent_mode can be enabled; if needed, update the handling in the LoRaConfig/ChannelSet application code so this field is rejected or ignored unless the caller is privileged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@meshtastic/config.proto`:
- Around line 1253-1258: The new transparent_mode field in LoRaConfig disables
encryption and mesh routing, so it must not be freely settable through ordinary
ChannelSet/lora_config exchange. Confirm and enforce the existing authorization
gate in the firmware/client path that applies Config.LoRaConfig updates, and
require an admin-authorized session (or equivalent privileged flow) before
transparent_mode can be enabled; if needed, update the handling in the
LoRaConfig/ChannelSet application code so this field is rejected or ignored
unless the caller is privileged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 200853ad-004e-4274-ba7f-360e26101b87
📒 Files selected for processing (1)
meshtastic/config.proto
Add transparent mode option for LoRa modem functionality.
9452d3a to
7f885c3
Compare
Adds another potential option for splitting layers with the client.
Summary by CodeRabbit