Guard against undefined values in the UI#990
Open
Avamander wants to merge 1 commit intomeshtastic:mainfrom
Open
Guard against undefined values in the UI#990Avamander wants to merge 1 commit intomeshtastic:mainfrom
Avamander wants to merge 1 commit intomeshtastic:mainfrom
Conversation
|
@Avamander is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For some reason
getMyNode()and/ornodecan beundefined, making the UI entirely unusable. Even after reconnecting to the node. Any other state is much more desirable than this.Related Issues
Fixes #982
Fixes #975
Fixes #960
Changes Made
Basic guards against potentially
undefinedvalues.Testing Done
For testing I made these changes to the (obfuscated) release build on client.meshtastic.org, it made the WebUI usable again. Unfortunately the source maps weren't available (why?) so I couldn't deobfuscate the stacktraces other people have reported, so I'm only 95% sure I added handling for those as well. Can't know for sure.
Checklist
CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)