feat(workspace): destroy safety — is-dirty check, auto-export, --discard#38
Closed
escherize wants to merge 1 commit into
Closed
feat(workspace): destroy safety — is-dirty check, auto-export, --discard#38escherize wants to merge 1 commit into
escherize wants to merge 1 commit into
Conversation
Destroy is the only irreversible moment, so it closes the work-loss window there: when a ws-<name> profile exists locally, the child is checked for unsynced work and a dirty workspace is auto-exported to its target branch before teardown. --discard skips both. No local profile warns and proceeds (destroy is the billing-stop lever; ops cleanup must work from any machine); an unreachable child refuses without --discard rather than silently reopening the window. The matching profile is dropped after a successful destroy. Refs GHY-4051
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Consolidated into #39. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs GHY-4051 (Linear). Stacked on the sweep PR.
Destroy is the only irreversible moment, so it closes the work-loss window there: when a
ws-<id>profile exists locally, the child is checked for unsynced work and a dirty workspace is auto-exported to its target branch before teardown (--discardskips both).--discard; unknown state doesn't silently reopen the window.is-dirtyround-trip), unreachable+--discardoverride, profile-drop verification. The dirty→auto-export path needs a configured git remote and is exercised in the local workspace testbed.