-
Notifications
You must be signed in to change notification settings - Fork 10
Update genesis SDK to v0.32.1 with bonding curve and agent support #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
e544421
b904753
582a367
f9939cc
f0822b4
0a56f0a
bcb38bb
742ab09
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -32,6 +32,32 @@ jobs: | |||||||||||||||||||||||||||||||||||
| with: | ||||||||||||||||||||||||||||||||||||
| node-version: ${{ matrix.node_version }} | ||||||||||||||||||||||||||||||||||||
| cache: pnpm | ||||||||||||||||||||||||||||||||||||
| - name: Install Solana CLI | ||||||||||||||||||||||||||||||||||||
| uses: metaplex-foundation/actions/install-solana@v1 | ||||||||||||||||||||||||||||||||||||
| with: | ||||||||||||||||||||||||||||||||||||
| version: ${{ env.SOLANA_VERSION }} | ||||||||||||||||||||||||||||||||||||
| cache: true | ||||||||||||||||||||||||||||||||||||
| - name: Dump latest programs from Devnet | ||||||||||||||||||||||||||||||||||||
| run: | | ||||||||||||||||||||||||||||||||||||
| declare -A PROGRAMS=( | ||||||||||||||||||||||||||||||||||||
| [".amman/mpl_token_metadata.so"]="metaqbxxUerdq28cj1RbAWkYQm3ybzjb6a8bt518x1s" | ||||||||||||||||||||||||||||||||||||
| [".amman/mpl_core.so"]="CoREENxT6tW1HoK8ypY1SxRMZTcVPm7R94rH4PZNhX7d" | ||||||||||||||||||||||||||||||||||||
| [".amman/mpl_distro.so"]="D1STRoZTUiEa6r8TLg2aAbG4nSRT5cDBmgG7jDqCZvU8" | ||||||||||||||||||||||||||||||||||||
| [".amman/mpl_core_candy_machine.so"]="CMACYFENjoBMHzapRXyo1JZkVS6EtaDDzkjMrmQLvr4J" | ||||||||||||||||||||||||||||||||||||
| [".amman/mpl_core_candy_guard.so"]="CMAGAKJ67e9hRZgfC5SFTbZH8MgEmtqazKXjmkaJjWTJ" | ||||||||||||||||||||||||||||||||||||
| [".amman/mpl_bubblegum.so"]="BGUMAp9Gq7iTEuizy4pqaxsTyUCBK68MDfK752saRPUY" | ||||||||||||||||||||||||||||||||||||
| [".amman/spl_noop.so"]="noopb9bkMVfRPU8AsbpTUg8AQkHtKwMYZiFUjNRtMmV" | ||||||||||||||||||||||||||||||||||||
| [".amman/mpl_noop.so"]="mnoopTCrg4p8ry25e4bcWA9XZjbNjMTfgYVGGEdRsf3" | ||||||||||||||||||||||||||||||||||||
| [".amman/mpl_account_compression.so"]="mcmt6YrQEMKw8Mw43FmpRLmf7BqRnFMKmAcbxE3xkAW" | ||||||||||||||||||||||||||||||||||||
| [".amman/spl_account_compression.so"]="cmtDvXumGCrqC1Age74AVPhSRVXJMd8PJS91L8KbNCK" | ||||||||||||||||||||||||||||||||||||
| [".amman/genesis.so"]="GNS1S5J5AspKXgpjz6SvKL66kPaKWAhaGRhCqPRxii2B" | ||||||||||||||||||||||||||||||||||||
| [".amman/mpl_agent_identity.so"]="1DREGFgysWYxLnRnKQnwrxnJQeSMk2HmGaC6whw2B2p" | ||||||||||||||||||||||||||||||||||||
| [".amman/mpl_agent_tools.so"]="TLREGni9ZEyGC3vnPZtqUh95xQ8oPqJSvNjvB7FGK8S" | ||||||||||||||||||||||||||||||||||||
| ) | ||||||||||||||||||||||||||||||||||||
| for file in "${!PROGRAMS[@]}"; do | ||||||||||||||||||||||||||||||||||||
| echo "Dumping ${PROGRAMS[$file]} -> $file" | ||||||||||||||||||||||||||||||||||||
| solana program dump -u devnet "${PROGRAMS[$file]}" "$file" | ||||||||||||||||||||||||||||||||||||
| done | ||||||||||||||||||||||||||||||||||||
|
Comment on lines
+57
to
+60
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add retry/backoff for Devnet dumps to reduce CI flakiness. Line 59 performs network-dependent dumps with no retry handling. A transient RPC failure will fail the whole job. Proposed hardening for file in "${!PROGRAMS[@]}"; do
echo "Dumping ${PROGRAMS[$file]} -> $file"
- solana program dump -u devnet "${PROGRAMS[$file]}" "$file"
+ for attempt in 1 2 3; do
+ if solana program dump -u devnet "${PROGRAMS[$file]}" "$file"; then
+ break
+ fi
+ if [ "$attempt" -eq 3 ]; then
+ echo "Failed after $attempt attempts: ${PROGRAMS[$file]} -> $file" >&2
+ exit 1
+ fi
+ sleep $((attempt * 5))
+ done
done📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||||
| - name: Start validator | ||||||||||||||||||||||||||||||||||||
| uses: metaplex-foundation/actions/start-validator@v1 | ||||||||||||||||||||||||||||||||||||
| with: | ||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "require": [ | ||
| "ts-node/register" | ||
| "tsx" | ||
| ], | ||
| "watch-extensions": [ | ||
| "ts" | ||
|
|
@@ -10,7 +10,9 @@ | |
| "timeout": 60000, | ||
| "parallel": true, | ||
| "node-option": [ | ||
| "loader=ts-node/esm", | ||
| "experimental-specifier-resolution=node" | ||
| "import=tsx" | ||
| ], | ||
| "ignore": [ | ||
| "test/commands/distro/**" | ||
|
Comment on lines
+15
to
+16
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do not globally disable the entire distro test suite in shared Mocha config. This permanently suppresses Suggested scoped approach- "ignore": [
- "test/commands/distro/**"
- ]
+ "ignore": [
+ "${MOCHA_IGNORE_GLOB}"
+ ]And set 🤖 Prompt for AI Agents |
||
| ] | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the MPL Agent Identity program ID mismatch.
Line 54 uses a different program ID than
.validator.cjsfor the same.amman/mpl_agent_identity.sopath. This can dump the wrong binary and make validator results unreliable.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents