-
Notifications
You must be signed in to change notification settings - Fork 10
Add command to add MPL Core Assets to Collections #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+70
−0
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| import { baseUpdateAuthority, fetchAsset, fetchCollection, update } from '@metaplex-foundation/mpl-core' | ||
| import { publicKey } from '@metaplex-foundation/umi' | ||
| import { Args } from '@oclif/core' | ||
| import ora from 'ora' | ||
|
|
||
| import { generateExplorerUrl } from '../../../explorers.js' | ||
| import { TransactionCommand } from '../../../TransactionCommand.js' | ||
| import umiSendAndConfirmTransaction from '../../../lib/umi/sendAndConfirm.js' | ||
| import { txSignatureToString } from '../../../lib/util.js' | ||
|
|
||
| export default class CollectionAdd extends TransactionCommand<typeof CollectionAdd> { | ||
| static override description = 'Add an existing MPL Core Asset to a Collection' | ||
|
|
||
| static override examples = [ | ||
| '<%= config.bin %> <%= command.id %> <collection> <asset>', | ||
| ] | ||
|
|
||
| static override args = { | ||
| collection: Args.string({ description: 'Collection to add the asset to', required: true }), | ||
| asset: Args.string({ description: 'Asset to add to the collection', required: true }), | ||
| } | ||
|
|
||
| public async run(): Promise<unknown> { | ||
| const { args } = await this.parse(CollectionAdd) | ||
| const { umi, explorer, chain } = this.context | ||
|
|
||
| const spinner = ora('Fetching asset and collection...').start() | ||
|
|
||
| try { | ||
| const asset = await fetchAsset(umi, publicKey(args.asset)) | ||
| const collection = await fetchCollection(umi, publicKey(args.collection)) | ||
|
|
||
| if (asset.updateAuthority.type === 'Collection') { | ||
| spinner.fail('Asset is already in a collection') | ||
| this.error(`Asset ${args.asset} already belongs to collection ${asset.updateAuthority.address}`) | ||
| } | ||
|
|
||
| spinner.text = 'Adding asset to collection...' | ||
|
|
||
| const txBuilder = update(umi, { | ||
| asset, | ||
| newUpdateAuthority: baseUpdateAuthority('Collection', [collection.publicKey]), | ||
| newCollection: collection.publicKey, | ||
| }) | ||
|
|
||
| const result = await umiSendAndConfirmTransaction(umi, txBuilder) | ||
| const signature = txSignatureToString(result.transaction.signature as Uint8Array) | ||
| const explorerUrl = generateExplorerUrl(explorer, chain, signature, 'transaction') | ||
|
|
||
| spinner.succeed(`Asset added to collection`) | ||
| this.logSuccess(`-------------------------------- | ||
| Asset: ${args.asset} | ||
| Collection: ${args.collection} | ||
| Signature: ${signature} | ||
| Explorer: ${explorerUrl} | ||
| --------------------------------`) | ||
|
|
||
| return { | ||
| asset: args.asset, | ||
| collection: args.collection, | ||
| signature, | ||
| explorer: explorerUrl, | ||
| } | ||
| } catch (error) { | ||
| if (!spinner.isSpinning) throw error | ||
| spinner.fail('Failed to add asset to collection') | ||
| throw error | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
Avoid unnecessary RPC on the early-reject path.
At Line 31,
fetchCollectionis called before checking whether the asset is already collection-bound (Line 33). If the asset is already in a collection, this does extra network work and latency for no benefit.♻️ Proposed refactor
Also applies to: 33-36
🤖 Prompt for AI Agents