Skip to content

feat: adding validation on 0 maxOfflineDiskEvents#24

Merged
choudlet merged 2 commits into
mainfrom
chrish/fix-validate-max-offline-disk-events
Apr 16, 2026
Merged

feat: adding validation on 0 maxOfflineDiskEvents#24
choudlet merged 2 commits into
mainfrom
chrish/fix-validate-max-offline-disk-events

Conversation

@choudlet

Copy link
Copy Markdown
Collaborator

Adding in Validation and Support for No Offline Mode when user configures 0 to maxOfflineDiskEvents

@github-actions

github-actions Bot commented Apr 16, 2026

Copy link
Copy Markdown

Test Results

 58 files  ± 0   58 suites  ±0   1m 3s ⏱️ -1s
474 tests +11  474 ✅ +11  0 💤 ±0  0 ❌ ±0 
948 runs  +22  948 ✅ +22  0 💤 ±0  0 ❌ ±0 

Results for commit 5303927. ± Comparison against base commit 3f3ce7f.

This pull request removes 3 and adds 14 tests. Note that renamed tests count towards both.
com.metarouter.analytics.InitOptionsTest ‑ custom maxOfflineDiskEvents accepted
com.metarouter.analytics.InitOptionsTest ‑ maxOfflineDiskEvents defaults to 10000
com.metarouter.analytics.queue.PersistableEventQueueTest ‑ offline disk overflow respects maxOfflineDiskEvents cap
com.metarouter.analytics.InitOptionsTest ‑ custom maxDiskEvents accepted
com.metarouter.analytics.InitOptionsTest ‑ does not warn when maxDiskEvents equals maxQueueEvents
com.metarouter.analytics.InitOptionsTest ‑ does not warn when maxDiskEvents exceeds maxQueueEvents
com.metarouter.analytics.InitOptionsTest ‑ does not warn when maxDiskEvents is zero (in-memory-only opt-out)
com.metarouter.analytics.InitOptionsTest ‑ maxDiskEvents defaults to 10000
com.metarouter.analytics.InitOptionsTest ‑ negative maxDiskEvents throws exception
com.metarouter.analytics.InitOptionsTest ‑ warns when maxDiskEvents is less than maxQueueEvents
com.metarouter.analytics.InitOptionsTest ‑ zero maxDiskEvents is accepted as in-memory-only opt-out
com.metarouter.analytics.queue.PersistableEventQueueTest ‑ enqueue at byte cap with zero disk drops oldest until fits and writes no disk file
com.metarouter.analytics.queue.PersistableEventQueueTest ‑ enqueue at event cap with zero disk drops oldest and writes no disk file
…

♻️ This comment has been updated with latest results.

@choudlet choudlet merged commit efd3a41 into main Apr 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant