feat: lifecycle storage foundation [rn] (1/4)#34
Open
choudlet wants to merge 1 commit into
Open
Conversation
Adds a dedicated AsyncStorage namespace (`metarouter:lifecycle:*`) for persisting last-seen `(version, build)`. Lives in its own module so neither `IdentityManager.reset()` nor `MetaRouterAnalyticsClient.reset()` can clear install/update history — lifecycle state is device-scope, not user-scope (parity with iOS `LifecycleStorage` and Android equivalent). Storage failures are swallowed and treated as 'no prior lifecycle state' so the caller can safely fall through to fresh-install or upgrade detection without try/catch noise at every read site. Slice 1 of 4 in the RN lifecycle stack (sc-36800).
Code Review - Hermes AgentLooks GoodNo common issues detected. Reviewed by Hermes Agent |
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metarouter:lifecycle:*AsyncStorage namespace plus thin async helpers (getLifecycleVersion,getLifecycleBuild,setLifecycleVersionBuild).MetaRouterAnalyticsClient.Stack
openURLpublic API + opt-in defaultTest plan
npx jest src/analytics/utils/lifecycleStorage.test.ts— 6 tests cover read, write, missing keys, and storage failures (best-effort swallow)npx tsc --noEmitclean