Harden Gmail errors with @lowerdeck helpers#43
Open
devdattatalele wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns Gmail with the google-meet/google-analytics/youtube error pattern.
Adds
gmail/src/lib/errors.tswithgmailServiceError,gmailApiError,gmailOAuthError. The Api/OAuth helpers useextractGoogleMessageto drill intodata.error.errors[].reason, tagdata.reason+data.upstreamStatus, andsetParent(error)to preserve the upstream stack.Replaces 20 raw
throw new Error(...)acrossauth.ts+ manage-draft / manage-labels / manage-settings / manage-thread withgmailServiceError. Wraps the OAuth callback / refresh / profile-lookup axios calls with try/catch +gmailOAuthError(operation, error)matching the youtube auth shape.Behavior unchanged on the happy path. Biome clean.