Skip to content

chore: bring repo into compliance with AGENTS.md #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
metyatech wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: bring repo into compliance with AGENTS.md #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
npm run verify
compose-agentsmd --compose || true
git add AGENTS.md || true
task-tracker check; npm run verify; compose-agentsmd --compose || true; git add AGENTS.md || true
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

task-tracker check is invoked directly in the pre-commit hook, but @metyatech/task-tracker is not a dependency in package.json/package-lock. On a clean machine this hook will fail unless the developer has a global install, which contradicts the repo rule that lifecycle hooks must succeed without global tool assumptions. Consider adding task-tracker as a devDependency and invoking it via the package manager executor (e.g., npm exec) so the hook is self-contained.

Suggested change
task-tracker check; npm run verify; compose-agentsmd --compose || true; git add AGENTS.md || true
npx task-tracker check; npm run verify; compose-agentsmd --compose || true; git add AGENTS.md || true

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Husky pre-commit hook is now a single command line without a shebang or Husky bootstrap, and it chains commands with ;. This can (a) fail to execute on Unix with an “exec format error” and (b) allow commits to succeed even when task-tracker check or npm run verify fails, because ; does not propagate failures and the hook exit code becomes the last command’s status. Convert this back to a normal Husky hook script (with the expected header) and ensure failures from task-tracker check and npm run verify stop the commit (e.g., via set -e or && chaining), while keeping the optional compose-agentsmd/git add behavior if desired.

Copilot uses AI. Check for mistakes.
1 change: 1 addition & 0 deletions .tasks.jsonl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"id":"rqZQhpxO","description":"Bring the repo into compliance with AGENTS.md (task-tracker setup, husky consolidation)","stage":"done","createdAt":"2026-03-10T06:00:12.192Z","updatedAt":"2026-03-10T06:02:31.536Z"}
Loading