-
Notifications
You must be signed in to change notification settings - Fork 0
test(router): add explicit coverage for llm → semantic routing #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
18e4804
1aaf786
54e9747
c7baaf8
3ac691a
d6169fc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,6 +31,20 @@ If critical input is missing, ask concise clarification questions first. | |
|
|
||
| ## Workflow | ||
|
|
||
| 0. RFC Gate (Architecture/Decision Precondition) | ||
| - Before deep refinement, detect whether foundational decisions are unresolved. | ||
| - Treat unresolved items as RFC blockers when they affect architecture, contracts, migration strategy, sequencing, security/compliance posture, or cross-team interfaces. | ||
| - RFCs must be human-in-the-loop friendly: | ||
| - Prefer one RFC per decision question (avoid bundling unrelated decisions). | ||
| - Keep each RFC digestible for a human reviewer (clear problem, options, trade-offs, recommendation, explicit decision request). | ||
| - Avoid overwhelming wall-of-text RFCs; split large topics into focused RFCs. | ||
| - If RFC blockers exist: | ||
| - Create or reference explicit RFC issue(s) that capture the open questions and decision options. | ||
| - Stop at RFC scope (do not produce full downstream implementation-ready sub-issue breakdown yet). | ||
| - State clearly that further refinement is blocked pending RFC resolution. | ||
| - Provide the minimal next-step checklist to unblock (owners, decision deadline, required outputs). | ||
| - If no RFC blockers exist, continue with full refinement workflow. | ||
|
|
||
| 1. Analyze Scope | ||
| - Read the epic and all linked issues fully. | ||
| - Identify unknowns, assumptions, constraints, and external dependencies. | ||
|
|
@@ -65,6 +79,23 @@ If critical input is missing, ask concise clarification questions first. | |
| - Add progress comments whenever substantive updates are made. | ||
| - Summarize decisions and rationale in each issue comment. | ||
|
|
||
| ## KISS Project-Management Heuristic | ||
|
|
||
| Default to the simplest tracking structure that preserves clarity. | ||
|
|
||
| - **Do not create sub-issues** when work is tightly coupled, likely delivered in one PR, and estimated to stay small (rule of thumb: **~500 LOC or less** total change across touched files). | ||
| - In those cases, keep a **single issue** with: | ||
| - one clear implementation approach, | ||
| - required vs preferred checklist items, | ||
| - one AC/DoD/Non-goal matrix. | ||
| - Only split into sub-issues when at least one of these is true: | ||
| - distinct owners or teams are expected, | ||
| - independent sequencing/blocking relationships are required, | ||
| - meaningful parallelization is possible without merge contention, | ||
| - scope is large/uncertain enough that one issue reduces clarity. | ||
|
|
||
| When uncertain, choose the single-issue path first and justify any split explicitly in the decision log. | ||
|
|
||
| ## Output Requirements | ||
|
|
||
| Deliverables must be clear, structured, and implementation-ready: | ||
|
|
@@ -103,11 +134,13 @@ A refinement is complete only when: | |
| - Dependencies and sequencing are explicit | ||
| - Coding agents can start without further product/architecture clarification | ||
|
|
||
| If unresolved foundational decisions are present, refinement is not complete: it must stop at RFC issue(s) and explicitly mark deeper refinement as blocked until RFCs are resolved. | ||
|
|
||
|
Comment on lines
+137
to
+138
|
||
| If the source issue has no DoD section, refinement is not complete until a proposed DoD is authored and published in the tracking artifacts. | ||
|
|
||
| ## Guardrails | ||
|
|
||
| - Do not implement code. | ||
| - Do not add unnecessary code examples. | ||
| - Prefer generic, technology-agnostic requirement language unless stack specifics are essential. | ||
| - Keep issue comments factual, decision-oriented, and audit-friendly. | ||
| - Keep issue comments factual, decision-oriented, and audit-friendly. | ||
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description states this is a test-only change to add coverage for
llm → semanticrouting in the query router test suite. However, this file contains changes to the refiner agent configuration that add RFC gate workflow steps and a KISS project-management heuristic.These changes appear unrelated to the stated purpose of the PR (adding test coverage) and should likely be in a separate PR focused on agent configuration improvements. Including unrelated changes makes it harder to review and understand the scope of each change.
Consider removing these agent configuration changes from this PR and submitting them separately if they are needed.