feat(loop): wire ui_review drive + deck-fit to pass viewport/interaction to the state slug

[mfittko]

Summary

Wires the production ui_review callers to the Stage-4 named-state slug seam (<state>-<viewport>-<interaction>). Stage 4 baked viewport + interaction-state into the slug and added a fail-closed duplicate-slug guard, but no production caller passed viewport/interaction — the discriminator was exercised only by the harness/unit contract. This ships the callers; it does not touch the seam or the slug format.

Scope and context

• packages/core/src/config/config.mjs: the drive-step schema gains optional viewport ({ width, height }) and interactionState (route-named enum) leaves, so a flow can declare a responsive/stateful render.
• scripts/loop/ui-review-drive.mjs: makeRunStep resizes the page to a declared viewport (via setViewportSize) and passes viewport + interactionState through to captureNamedUiState, so responsive/stateful renders become distinct slugged directories in production, not just in tests. Because the Playwright page stays resized across steps, an undeclared later step inherits the last explicitly-set viewport — so its slug faithfully reflects the size the page is actually at rather than mislabelling it default; default still applies to a never-resized flow.
• test/playwright/harness/deck-fit-harness.mjs: drops the (mobile 390) name-hack from the mobile captures and passes viewport: MOBILE instead — the slug now carries the viewport rather than the state-name string.
• test/contracts/deck-fit-harness-viewport-contract.test.mjs (new): a source-level pin (runs under test:assets, so part of verify) asserting the harness makes ≥2 viewport: MOBILE capture calls and embeds no viewport hack (mobile/390) in any stateName — so a revert of the name-hack removal is caught by verify, not only by a live browser spec.
• docs/ui-review-recipe-contract.md + test/docs/ui-review-recipe-doc.test.mjs: document the two new schema fields (three leaves: viewport.width, viewport.height, interactionState) and update the leaf count accordingly.

Acceptance criteria

Satisfies #1321's ACs (checked off at merge): the live drive passes viewport/interactionState to captureNamedUiState so responsive/stateful renders slug distinctly in production; the deck-fit harness passes viewport instead of encoding it into the state name; harnesses that capture a state at multiple viewports use the slug discriminator, not a name hack; npm run verify green with existing named-state artifacts still validating.

Non-goals

Auto-enumerating interaction states (the spec/route names them; #1300 non-goal). Changing the slug format or the fail-closed guards shipped in #1300.

Validation

• node --test test/loop/ui-review-drive.test.mjs test/loop/ui-smoke-harness.test.mjs — 50 pass (a caller now emits distinct viewport-slugged directories; the deck-fit name hack is gone); packages/core/test/config.test.mjs — 313 pass; test/docs/ui-review-recipe-doc.test.mjs — 2 pass.
• npm run verify — green (test:assets 191, test:scripts 2700, test:extension 81, test:core, test:docs, test:pack, test:dev-loop 32); generate-claude-assets --check clean.

Closes #1321

[Copilot]

Pull request overview

This PR completes the Stage-4 ui_review wiring by ensuring production callers pass viewport and interactionState through to captureNamedUiState, so named-state artifact slugs (<state>-<viewport>-<interaction>) uniquely and correctly represent responsive/stateful renders outside of the test harness.

Changes:

• Extend the ui_review drive-step config schema to allow optional viewport {width,height} and interactionState.
• Update the live UI-review drive to apply a declared viewport and forward viewport/interactionState into captureNamedUiState.
• Remove the deck-fit “(mobile 390)” state-name hack and instead pass viewport: MOBILE; update the recipe contract docs and schema-leaf count test.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
test/playwright/harness/deck-fit-harness.mjs	Passes viewport: MOBILE so mobile/desktop captures disambiguate via slug rather than state-name text.
test/loop/ui-review-drive.test.mjs	Adds regression coverage for viewport/interactionState slugging in the production drive wiring.
test/docs/ui-review-recipe-doc.test.mjs	Updates the expected uiReview/worktree schema leaf count to reflect new keys.
scripts/loop/ui-review-drive.mjs	Applies step viewport before actions and forwards viewport/interactionState to the named-state capture seam.
packages/core/test/config.test.mjs	Adds schema validation tests for the new step leaves and fail-closed invalid values.
packages/core/src/config/config.mjs	Extends UiReviewFlowStepConfig with optional viewport and interactionState.
docs/ui-review-recipe-contract.md	Documents the new schema leaves and includes them in the canonical key list.

[mfittko]

Gate review: draft_gate

Reviewed head SHA: 051092dcedab578a109e6ff9711193f4c6d2b2d8
Verdict: clean
Execution mode: fanout_fanin

Findings summary: 6 angles reviewed; no findings (see per-angle breakdown below).

• pr-description → clean
• scope → clean
• correctness → clean
• coverage → clean
• code-conformance → clean
• contract-surface → clean

Next action: Draft gate clean at head 051092d (6 distinct reviewers; contract-surface carried from 28b5c58). Mark ready; request Copilot review.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

[mfittko]

Gate review: pre_approval_gate

Reviewed head SHA: 980a74eb8514ba7f896f577f5fcb3c9286fe3c8e
Verdict: clean
Execution mode: fanout_fanin

Findings summary: 5 angles reviewed; no findings (see per-angle breakdown below).; Copilot review rounds exhausted (2/2); current head has zero unresolved threads and green or credibly green CI, so pre_approval_gate fallback is allowed without another Copilot re-request.

• pr-checklist-matrix → clean
• acceptance-criteria → clean
• yagni → clean
• contradiction-lens → clean
• correctness-final → clean

Next action: Pre-approval gate clean at head 980a74e (5 distinct reviewers). CI green; Copilot converged (3 rounds; doc-only bump carried forward, round-cap-clean). Proceed to merge.