Implement InterestEvent and set source property#9
Merged
keithamus merged 4 commits intomfreed7:mainfrom Feb 27, 2026
Merged
Conversation
keithamus
reviewed
Feb 24, 2026
mfreed7
approved these changes
Feb 24, 2026
Owner
mfreed7
left a comment
mfreed7
left a comment
There was a problem hiding this comment.
This looks roughly good to me, modulo the cancelability of the events.
Added 2nd parameter to clearState to detect Esc key case.
keithamus
reviewed
Feb 25, 2026
Collaborator
keithamus
left a comment
keithamus
left a comment
There was a problem hiding this comment.
Couple of small comments, but overall this LGTM I think.
Owner
|
Ready to merge it? |
Contributor
Author
I think so, waiting for @keithamus to approve. |
Contributor
Author
|
@mfreed7 please publish to npm when you get a chance so the update can be consumed publicly. |
Owner
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporates feedback from #7