Raise error if FCurve param def is missing get_divisions#638
Open
timothyliu3d wants to merge 1 commit into
Open
Raise error if FCurve param def is missing get_divisions#638timothyliu3d wants to merge 1 commit into
get_divisions#638timothyliu3d wants to merge 1 commit into
Conversation
…has not implemented its `get_divisions` method
Member
|
Hi @timothyliu3d Thanks for the PR. I will check it ASAP |
miquelcampos
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Update
ComponentGuide.get_divisionsto raise aNotImplementedErrorwith a clearer error message.This happens when a component has an FCurve param def, but does not implement
get_divisions.Compared to the current behavior, which is a generic error message (
TypeError: unsupported operand type(s) for -: 'NoneType' and 'float'), this better points towards the source of the problem.Want to also point out:
get_divisionsis only called in theshifter.guidebase class, but not implemented, while it is only implemented in theshifter.component.guidesubclass, but never called, adding to the unclarity when tracing through.Testing Done
Maya 2027
mGear 5.3.3
Able to successfully build "EPIC_mannequin_y_up" template.
Related Issue(s)
N/A