Skip to content

Changes for supporting DataFormatRegistry #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bukhtawar wants to merge 3 commits into
base: os-abstraction
Choose a base branch
from
Open

Changes for supporting DataFormatRegistry #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eae9a8a
Add indexer interface for shard interaction with underlying engines
mgodwan Feb 19, 2026
11cadef
add missing pkg info
mgodwan Mar 6, 2026
3a17a39
Changes for supporting DataFormatRegistry
Bukhtawar Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/src/internalClusterTest/java/org/opensearch/index/shard/IndexShardIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,7 +852,7 @@ public void testNoOpEngineFactoryTakesPrecedence() {
final IndexService indexService = indicesService.indexServiceSafe(indexMetadata.getIndex());

for (IndexShard indexShard : indexService) {
assertThat(indexShard.getEngine(), instanceOf(NoOpEngine.class));
assertThat(indexShard.getIndexer(), instanceOf(NoOpEngine.class));
}
}

Expand Down
4 changes: 2 additions & 2 deletions ...src/internalClusterTest/java/org/opensearch/snapshots/SharedClusterSnapshotRestoreIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@

import static org.opensearch.cluster.metadata.IndexMetadata.SETTING_NUMBER_OF_SHARDS;
import static org.opensearch.cluster.routing.allocation.decider.MaxRetryAllocationDecider.SETTING_ALLOCATION_MAX_RETRY;
import static org.opensearch.index.shard.IndexShardTests.getEngineFromShard;
import static org.opensearch.index.shard.IndexShardTestCase.getEngine;
import static org.opensearch.indices.recovery.RecoverySettings.INDICES_RECOVERY_MAX_BYTES_PER_SEC_SETTING;
import static org.opensearch.test.hamcrest.OpenSearchAssertions.assertAcked;
import static org.opensearch.test.hamcrest.OpenSearchAssertions.assertAllSuccessful;
Expand Down Expand Up @@ -2052,7 +2052,7 @@ public void testSnapshottingWithMissingSequenceNumbers() {
final Index index = resolveIndex(indexName);
final IndexShard primary = internalCluster().getInstance(IndicesService.class, dataNode).getShardOrNull(new ShardId(index, 0));
// create a gap in the sequence numbers
EngineTestCase.generateNewSeqNo(getEngineFromShard(primary));
EngineTestCase.generateNewSeqNo(getEngine(primary));

for (int i = 5; i < 10; i++) {
index(indexName, "_doc", Integer.toString(i), "foo", "bar" + i);
Expand Down
1 change: 0 additions & 1 deletion server/src/main/java/org/opensearch/index/engine/Engine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2234,5 +2234,4 @@ public long getMaxSeenAutoIdTimestamp() {
* to advance this marker to at least the given sequence number.
*/
public abstract void advanceMaxSeqNoOfUpdatesOrDeletes(long maxSeqNoOfUpdatesOnPrimary);

}
Loading