feat: add Bun runtime support with SQLite adapter abstraction

[mherod]

Summary

Implements comprehensive Bun runtime support by adding a runtime-aware SQLite adapter layer. This enables the get-cookie package to work seamlessly with both Node.js (via better-sqlite3) and Bun (via bun:sqlite) without requiring code changes from users.

Previous work: Downgraded is-bun-module to resolve Node.js ESM loading errors.

What Changed

New Adapter Layer (src/core/browsers/sql/adapters/)

• DatabaseAdapter.ts: Core abstraction defining SqliteDatabase and SqliteStatement interfaces with runtime detection and factory function
• BetterSqlite3Adapter.ts: Wrapper around better-sqlite3 for Node.js environments
• BunSqliteAdapter.ts: Wrapper around bun:sqlite for Bun environments
• index.ts: Module exports for the adapter layer

Core Updates

• DatabaseConnectionManager: Changed to use createSqliteDatabase() factory instead of direct BetterSqlite3 instantiation
• QueryMonitor: Updated all method signatures to accept abstract SqliteDatabase type
• EnhancedCookieQueryService: Updated query callbacks to use abstract types
• Tests: Refactored to mock the adapter factory rather than the concrete BetterSqlite3 implementation

Key Benefits

✅ Zero Breaking Changes: All existing code continues to work unchanged
✅ Type Safe: Full TypeScript support with abstract interfaces
✅ Lightweight: Minimal 6-method API surface (prepare, pragma, close, all, get, run)
✅ Automatic Detection: Runtime detection via globalThis.Bun check
✅ Dynamic Imports: Adapters lazily loaded only when needed

Why

Addresses issue #405 by implementing Bun runtime support using the adapter pattern. This follows SOLID principles and makes the codebase extensible for future SQLite implementations without modifying existing code.

Testing

• ✅ All 520 tests passing
• ✅ Type checking clean (tsc --noEmit)
• ✅ Linting passed (biome check)
• ✅ Build successful (tsup)
• ✅ Full validation suite passing

Implementation Quality

The adapter pattern provides:

• Clean separation of concerns
• Easy to test (mock adapter factory)
• No monkey-patching or global state
• Future-proof extensibility
• Zero impact on public API

Risk / Rollout

Risk Level: Low

• Pure abstraction layer addition
• All existing Node.js functionality unchanged
• Comprehensive test coverage maintained
• No external dependencies added for Bun support (built-in)

Rollout: Immediate - ready for production

• Can be released in next minor version as new Bun support feature

---

🤖 Generated with Claude Code

[claude]

PR Review: Bun Runtime SQLite Adapter Abstraction

Overview

This PR introduces a clean adapter pattern to abstract SQLite operations, enabling get-cookie to work with both Node.js (better-sqlite3) and Bun (bun:sqlite). The abstraction layer is well-structured. The original critical blocker has been fixed.

Findings

🔴 Critical

• fileMustExist silently ignored in BunSqliteAdapter — Fixed. BunSqliteAdapter now correctly passes { create: false } when fileMustExist: true, matching better-sqlite3 semantics and ensuring missing cookie database paths surface as errors.

🟡 Warnings

• is-bun-module force-downgraded via pnpm override (package.json)
  Still present. The override pins a transitive dependency to an older version, which will drift as the ecosystem evolves. Worth tracking upstream or documenting why 2.x breaks Node.js ESM loading. Not a blocker.

• No tests for new adapter code
  BetterSqlite3Adapter, BunSqliteAdapter, detectRuntime(), and getCurrentRuntime() still have no unit tests. BetterSqlite3Adapter and runtime detection are straightforward to test in Node.js CI. Follow-up issue would be fine.

🔵 Suggestions

• pragma() return type widened from void to unknown — Fixed.

• BunSqliteAdapter.pragma() always returns undefined (BunSqliteAdapter.ts)
  Now that the interface signals unknown (implying callers may get meaningful return values), the Bun adapter's use of exec() silently discards results. Any caller using pragma() to read values (e.g. PRAGMA journal_mode) will get undefined on Bun but actual data on Node.js. For the current codebase this doesn't matter (only busy_timeout is set, not read), but it's a latent behavioural inconsistency. Bun's db.prepare("PRAGMA ...").get() would handle the read case if needed later.

👍 What's Good

• Clean separation of concerns — the SqliteDatabase/SqliteStatement interfaces are minimal and correct
• Lazy dynamic loading of adapters means Node.js users never touch bun:sqlite imports
• Tests are properly updated to mock at the abstraction boundary rather than the concrete implementation
• bun:sqlite correctly marked as external in both tsup configs — prevents bundler errors
• BetterSqlite3Adapter faithfully forwards all options including fileMustExist

Summary

The original blocker is resolved. Remaining items are warnings/suggestions that don't affect correctness for the current use cases. This is ready to merge as-is if the test gap is acceptable as a follow-up.

[mherod]

Summary of Changes

All review feedback has been addressed:

🔴 Critical (fixed)

• BunSqliteAdapter now honours fileMustExist — Bun's Database constructor creates new files by default. When fileMustExist: true is passed, we now explicitly set { create: false } to match better-sqlite3 semantics and ensure missing cookie database paths surface as errors rather than silently producing empty results.

🟡 Warnings (addressed)

• bun:sqlite marked as external in tsup configs — Added "bun:sqlite" to the external array in both tsup.lib.ts and tsup.cli.ts. Since bun:sqlite is a Bun runtime built-in, the bundler cannot resolve it; marking it external makes the lazy-loading intent explicit and prevents esbuild from attempting to bundle it in the Node.js build.

🔵 Suggestions (implemented)

• pragma() return type widened from void to unknown — better-sqlite3's pragma() returns data (e.g. PRAGMA journal_mode returns the current mode). The interface now uses unknown to preserve this capability without compromising type safety. Both concrete adapters updated accordingly.

All checks pass locally: pnpm type-check, pnpm lint, pnpm test (520 tests passing). CI is running.

[claude]

Critical blocker resolved — BunSqliteAdapter now correctly honours fileMustExist via Bun's create: false option. pragma() return type widened appropriately and bun:sqlite correctly marked external in both tsup configs. Remaining items (adapter unit tests, is-bun-module override, pragma() read semantics on Bun) are non-blocking for the current use cases. LGTM.