Skip to content

bugfix (#249)#250

Merged
pablogs9 merged 1 commit into
micro-ROS:jazzyfrom
shvass:jazzy
Sep 9, 2024
Merged

bugfix (#249)#250
pablogs9 merged 1 commit into
micro-ROS:jazzyfrom
shvass:jazzy

Conversation

@shvass

@shvass shvass commented Aug 2, 2024

Copy link
Copy Markdown
Contributor

atomic patch no more deletes current working directory

atomic patch no more deletes current working directory
@pablogs9

Copy link
Copy Markdown
Member

Why this order change solves your issue?

@shvass

shvass commented Sep 8, 2024

Copy link
Copy Markdown
Contributor Author

well, here libmicroros.mk the path specified to rm command happens to be the current working directory, which results in uncertain behavior.

just switching to another directory before performing rm fixes the issue

@pablogs9 pablogs9 merged commit 002cbc1 into micro-ROS:jazzy Sep 9, 2024
@pablogs9

pablogs9 commented Sep 9, 2024

Copy link
Copy Markdown
Member

@mergify backport humble iron

@mergify

mergify Bot commented Sep 9, 2024

Copy link
Copy Markdown
Contributor

backport humble iron

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Sep 9, 2024
atomic patch no more deletes current working directory

(cherry picked from commit 002cbc1)
@mergify mergify Bot mentioned this pull request Sep 9, 2024
mergify Bot pushed a commit that referenced this pull request Sep 9, 2024
atomic patch no more deletes current working directory

(cherry picked from commit 002cbc1)
@mergify mergify Bot mentioned this pull request Sep 9, 2024
pablogs9 pushed a commit that referenced this pull request Sep 9, 2024
atomic patch no more deletes current working directory

(cherry picked from commit 002cbc1)

Co-authored-by: akshay bansod <akshayb@gmx.com>
pablogs9 pushed a commit that referenced this pull request Sep 9, 2024
atomic patch no more deletes current working directory

(cherry picked from commit 002cbc1)

Co-authored-by: akshay bansod <akshayb@gmx.com>
@4ntn

4ntn commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

@mergify backport rolling

@mergify

mergify Bot commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

backport rolling

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Jun 5, 2025
atomic patch no more deletes current working directory

(cherry picked from commit 002cbc1)
@mergify mergify Bot mentioned this pull request Jun 5, 2025
4ntn pushed a commit that referenced this pull request Jun 5, 2025
atomic patch no more deletes current working directory

(cherry picked from commit 002cbc1)

Co-authored-by: akshay bansod <akshayb@gmx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants