Fixed PC explained vars in joint-RPCA#826
Merged
Merged
Conversation
Member
Author
|
Checks fail on Win & Mac but afaik this is not related to this PR but to Bioc updates with the new release. Could we merge this @TuomasBorman |
TuomasBorman
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the discrepancy in expained variance w.r.t. Gemelli.
The reason was the sorting of svd values (descending vs. ascending); this had been noted elsewhere in the code but was left undone on line 728 of R/getRPCA.R
Now the explained variances match between mia ("percentVar") and Gemelli.