Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Upgrading unused lodash dependency in two packages
- Removed unused lodash dependency from both metascraper-audio and metascraper-video package.json files as it was replaced with native loops in PR #811 but never cleaned up.
Or push these changes by commenting:
@cursor push 3e8e96ec22
Preview (3e8e96ec22)
diff --git a/packages/metascraper-audio/package.json b/packages/metascraper-audio/package.json
--- a/packages/metascraper-audio/package.json
+++ b/packages/metascraper-audio/package.json
@@ -24,7 +24,6 @@
],
"dependencies": {
"@metascraper/helpers": "workspace:*",
- "lodash": "~4.18.0",
"p-reflect": "~2.1.0"
},
"devDependencies": {
diff --git a/packages/metascraper-video/package.json b/packages/metascraper-video/package.json
--- a/packages/metascraper-video/package.json
+++ b/packages/metascraper-video/package.json
@@ -24,7 +24,6 @@
],
"dependencies": {
"@metascraper/helpers": "workspace:*",
- "lodash": "~4.18.0",
"p-reflect": "~2.1.0"
},
"devDependencies": {You can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit 33fe8a8. Configure here.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


closes #835
Note
Medium Risk
Moderate risk due to a
lodashversion bump across multiple packages and a small API surface change inmetascraper-telegram(injectablegetIframe) that could affect scraping behavior if misused.Overview
Upgrades
lodashusage across several packages (including removing it where unused inmetascraper-audio/metascraper-video, and bumping to~4.18.0in others).Makes the test suite less flaky by skipping YouTube media-provider tests on CI, replacing several broad snapshots with targeted assertions (Instagram, manifest, multiple integration fixtures), and loosening logo checks to accept
nullor any validhttp(s)URL.Extends
metascraper-telegramto accept an optionalgetIframeimplementation (typed inindex.d.tsand wired into memoization) and adjusts its tests to run fully offline via fixtures; also updates the package test script to run serially without worker threads.Reviewed by Cursor Bugbot for commit c154283. Bugbot is set up for automated code reviews on this repo. Configure here.