requests: Fix protocol-relative redirect Locations.#1141
Open
pablogventura wants to merge 1 commit into
Open
Conversation
Handle Location values that start with "//" before absolute-path rewrites so they keep the redirect host. Fixes micropython#931. Signed-off-by: Pablo Ventura <pablogventura@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #931 / commit 8b7a02e, which already rewrites absolute-path
Locationvalues such as/indexonto the current host.That rewrite used
startswith("/"), which also matches protocol-relativeURLs (
//host/path) and incorrectly prepends the original host. Handle//first by prefixing only the current scheme so the redirect host ispreserved.
Path-relative Locations without a leading
/(for exampleindex) arestill not resolved.
Fixes #931.
Testing
micropython python-ecosys/requests/test_requests.pypasses,including a new
test_redirect_protocol_relativecase.__init__.mpysize withmpy-crossvsupstream/master: 2987 -> 3028bytes (+41).
Trade-offs and Alternatives
//) Locations are added here. Absolute-path(
/) support remains as in 8b7a02e./stay unsupported to keep the diffand bytecode small.
Generative AI
I used generative AI tools when creating this PR, but a human has checked the
code and is responsible for the code and the description above.