datetime: Add default utc tz for datetime.now().#570
Closed
ThinkTransit wants to merge 3 commits into
Closed
Conversation
Signed-off-by: Patrick Joy <patrick@joytech.com.au>
|
+1, it would be good to have at least something, like the previous implementation which also had shortcomings but at least had a functioning |
Contributor
Author
Contributor
|
I'm not in favor of this merge. From CPython 3.11.5 documentation, |
Member
|
This has been superseded by #1045. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a reauthor of #561
The datetime module doesn't support naive datetimes and throws an unimplemented error when calling some of the methods such as datetime.now().
Rather than passing a tz object to these methods on each call I feel it would be best to use a default tz (utc) when a tz isn't provided. This would be more CPython compliant for the end user.
This pr adds a default utc timezone in fromtimestamp() if no tz is supplied.
Signed-off-by: Patrick Joy patrick@joytech.com.au