Expand unit test coverage for metric-engine and rule-engine#49
Merged
aymenfurter merged 2 commits intoMay 25, 2026
Merged
Conversation
Copilot
AI
changed the title
[WIP] Add unit tests for metric-engine.ts and rule-engine.ts
Expand unit test coverage for metric-engine and rule-engine
May 24, 2026
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
aymenfurter
approved these changes
May 24, 2026
san360
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core evaluation engines (
metric-engine.ts,rule-engine.ts) were only exercised indirectly throughantipatterns-e2e.test.ts, leaving regressions invisible to the test suite.Changes
metric-engine.test.ts(+20 tests)evaluateMetricedge cases: empty datasets, no matches, missing/null fields, default example fallback,avg(field)aggregation, 3-row example cap.evaluateTrigger,calibrate, andrunTestCases.calibrateedge cases: empty rows, non-numeric filter field (null distribution),sessionsscope derivation.serializeCalibration/stripCalibrationround-trip, including the no-distribution and no-op branches.parseRuleExtensionswith inline-arrayrequires, malformed JSON test cases (skipped silently), and bodies without frontmatter.parseMetricdefaults (scope, aggregation, version) and missing-id rejection.rule-engine.test.ts(+1 test)evaluateRulereturnspct: '0%'whencount > 0buttotal === 0(avoids divide-by-zero in templates).Coverage on
metric-engine.tsmoves from ~86% lines to near-complete;rule-engine.tsremains at ~98% with the divide-by-zero branch now pinned.