Specify versions for agent-framework packages#239
Open
shunishii wants to merge 1 commit intomicrosoft:mainfrom
Open
Specify versions for agent-framework packages#239shunishii wants to merge 1 commit intomicrosoft:mainfrom
shunishii wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Because the latest Agent Framework includes breaking changes, this sample no longer works when imported. As a temporary workaround, I changed Agent Framework to a version from before those breaking changes.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the Python Agent Framework sample reproducible again by pinning Agent Framework dependencies to a known-working pre-breaking-change version.
Changes:
- Pin
agent-framework-coreandagent-framework-azure-aito1.0.0b260128in the sample’spyproject.toml.
Comment on lines
+10
to
+11
| "agent-framework-core==1.0.0b260128", | ||
| "agent-framework-azure-ai==1.0.0b260128", |
There was a problem hiding this comment.
Pinning Agent Framework packages with strict == to a specific beta build can make the sample brittle (e.g., if that build is yanked). If you know the first breaking version, consider using a bounded range (>=<known_good>,<first_bad>) and/or add an inline note linking to the breaking change so it’s clear when to revisit the pin.
Suggested change
| "agent-framework-core==1.0.0b260128", | |
| "agent-framework-azure-ai==1.0.0b260128", | |
| "agent-framework-core>=1.0.0b260128,<1.1.0", | |
| "agent-framework-azure-ai>=1.0.0b260128,<1.1.0", |
Author
|
Related to #221 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the latest Agent Framework includes breaking changes, this sample no longer works when imported. As a temporary workaround, I changed Agent Framework to a version from before those breaking changes.