cleanup: remove service references from docs and code#317
Merged
sellakumaran merged 1 commit intomainfrom Mar 12, 2026
Merged
Conversation
Remove all references to the internal MOS (Microsoft Online Services) Titles service that were left over after PR #315 stripped the upload logic from the publish command. - Rewrite DEVELOPER.md publish section to reflect zip-only workflow - Update README.md, design.md, and subdirectory READMEs accordingly - Remove dead MOS error codes from ErrorCodes.cs and ErrorMessages.cs - Update deprecation messages in CreateInstanceCommand and A365CreateInstanceRunner - Fix comment in PermissionsSubcommand referencing "MOS Power Platform API" - Remove stale MosConstants, MosTokenService, AgentPublishService, PublishHelpers entries from README docs (those files no longer exist) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes leftover references to the internal MOS (Microsoft Online Services) Titles service from documentation and code, following PR #315 which stripped the actual upload logic from the publish command.
Changes:
- Rewrites documentation (DEVELOPER.md, design.md, README files) to reflect the new zip-only publish workflow targeting the Microsoft 365 Admin Center
- Removes MOS-related error codes, error messages, and constants documentation
- Updates deprecation messages in
CreateInstanceCommandandA365CreateInstanceRunnerto use generic terminology instead of MOS references
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates publish command description to reflect manifest packaging workflow |
| src/DEVELOPER.md | Major rewrite of publish section: removes MOS auth, prerequisites, and token details |
| docs/design.md | Replaces MOS Titles Service with Microsoft 365 Admin Center in architecture diagram |
| docs/ai-workflows/README.md | Updates publish description |
| docs/ai-workflows/quick-reference.md | Updates publish comment and removes MOS_TITLES_URL env var |
| docs/ai-workflows/integration-test-workflow.md | Updates publish test descriptions |
| src/.../design.md | Removes MOS references from file tree and requirement checks table |
| src/.../Commands/README.md | Updates publish command description |
| src/.../Commands/CreateInstanceCommand.cs | Replaces MOS terminology in deprecation messages |
| src/.../Services/A365CreateInstanceRunner.cs | Replaces MOS terminology in deprecation warnings |
| src/.../Services/README.md | Removes AgentPublishService and MosTokenService entries |
| src/.../Helpers/README.md | Removes PublishHelpers section |
| src/.../Constants/README.md | Removes MosConstants section and MOS error message examples |
| src/.../Constants/ErrorMessages.cs | Removes MOS token and prerequisites error messages |
| src/.../Constants/ErrorCodes.cs | Removes MOS-related error codes |
| src/.../Commands/SetupSubcommands/PermissionsSubcommand.cs | Removes "MOS" prefix from Power Platform API comment |
You can also share your feedback on Copilot code review. Take the survey.
ajmfehr
changed the title
ajmfehr
approved these changes
Mar 12, 2026
gwharris7
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove all references to the internal reference in publish command that were left over after PR #315 stripped the upload logic from the publish command.