Bugs/632378 make quality inspection gen rule warning actionable#7938
Bugs/632378 make quality inspection gen rule warning actionable#79386CRIPT wants to merge 21 commits into
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
AL Documentation Audit
Documentation gaps were detected in the following apps:
- Quality-Management: 88% documentation coverage
To generate documentation, run /al-docs init or /al-docs update using GitHub Copilot CLI or Claude Code.
This review is for awareness to help keep documentation in sync with code changes. It is okay to dismiss this request.
|
Right now, the state of the PR, when choosing a template with no valid gen rules: If the user tries to create a gen rule without a table, the page throws an error: 
So the user needs to choose a table for then gen rules. |
|
Also, during the process of this fix, I faced these errors not related with this PR: `Compilation started for project 'Quality Management' containing '215' files at '11:47:09.863'. c:\depot\NAV\App\BCApps\src\Apps\W1\Quality Management\app\src\Dispositions\InventoryAdjustment\QltyDispNegAdjustInv.Codeunit.al(65,24): error AL0920: The method 'PerformDisposition' cannot be used as the implementation for the interface method 'Qlty. Disposition.PerformDisposition' because it is not public. This warning will become an error when targeting a runtime with version '19.0' or higher. Compilation ended at '11:47:10.573'. Error: The package could not be created.` I simply replaced those internal procedures for public ones. However I did not commit those changes because they are not related tothe PR. Lets see whether the tests pass regardless. |
…able for the gen rule, another error will be thrown telling the user that he needs to navigate back to gen inspection rules Co-authored-by: Copilot <copilot@github.com>
…es a valid source but without a source table assigned, then BC throws the error but giving the user the option to navigate directly to the gen rules page instead
6CRIPT
force-pushed
the
bugs/632378-make-quality-inspection-gen-rule-warning-actionable
branch
from
57c683c to
d8bba87
Compare
|
Changes from main pulled to see whether tests pass or not now. |
…ert so we dont get early validation errors.
… field as editable, and it shouldn't. also reverted some changes that were made to achieve the red asterix that are no longer necessary.
…-warning-actionable
This comment was marked as resolved.
This comment was marked as resolved.
…tionable' of https://github.com/microsoft/BCApps into bugs/632378-make-quality-inspection-gen-rule-warning-actionable
… times, instead if he wants try to retry he just needs to click on the lookup
|
…ity-inspection-gen-rule-warning-actionable
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
|
This comment was marked as low quality.
This comment was marked as low quality.
|
3 participants
Fixes AB#632378